From: Alex Tomas <alex@clusterfs.com>
To: "Amit K. Arora" <aarora@linux.vnet.ibm.com>
Cc: linux-ext4@vger.kernel.org, suparna@in.ibm.com, cmm@us.ibm.com,
alex@clusterfs.com
Subject: Re: [PATCH 1/1] Extent overlap bugfix in ext4
Date: Tue, 02 Jan 2007 12:25:21 +0300 [thread overview]
Message-ID: <m364bpn5ku.fsf@bzzz.home.net> (raw)
In-Reply-To: <20070102090909.GA20503@amitarora.in.ibm.com> (Amit K. Arora's message of "Tue\, 2 Jan 2007 14\:39\:09 +0530")
>>>>> Amit K Arora (AKA) writes:
AKA> The ext4_ext_get_blocks() and ext4_ext_insert_extent() routines do not
AKA> check for extent overlap, when a new extent needs to be inserted in an
AKA> inode. An overlap is possible when the new extent being inserted has
AKA> ee_block that is not part of any of the existing extents, but the
AKA> tail/center portion of this new extent _is_. This is possible only when
AKA> we are writing/preallocating blocks across a hole.
not sure I understand ... you shouldn't insert an extent that overlap
any existing extent. when you write block(s), you first check is
it already allocated and insert new extent only if it's not. for
preallocated block(s), you should adapt existing extent(s) so that
they don't overlap new extent you're inserting. am I missing something?
also, I think that modification of existing extent(s) (not merging)
isn't safe.
thanks, Alex
next prev parent reply other threads:[~2007-01-02 9:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 9:09 [PATCH 1/1] Extent overlap bugfix in ext4 Amit K. Arora
2007-01-02 9:25 ` Alex Tomas [this message]
2007-01-02 9:47 ` Amit K. Arora
2007-01-03 9:44 ` Alex Tomas
2007-01-03 18:07 ` Mingming Cao
2007-01-04 8:13 ` Amit K. Arora
2007-01-04 10:04 ` Alex Tomas
2007-01-04 18:23 ` Mingming Cao
2007-01-03 1:35 ` Mingming Cao
2007-01-03 6:06 ` Amit K. Arora
2007-01-04 8:54 ` [PATCH 1/1 version2] " Amit K. Arora
2007-01-04 10:25 ` Alex Tomas
2007-01-04 11:16 ` Amit K. Arora
2007-01-04 10:39 ` Alex Tomas
2007-01-04 11:27 ` Amit K. Arora
2007-01-04 11:37 ` Alex Tomas
2007-01-04 17:23 ` Amit K. Arora
2007-01-04 18:50 ` Mingming Cao
2007-01-04 19:19 ` Alex Tomas
2007-01-05 12:13 ` Amit K. Arora
2007-01-09 5:51 ` [PATCH 1/1 version3] " Amit K. Arora
2007-01-04 19:03 ` [PATCH 1/1 version2] " Alex Tomas
2007-01-04 19:47 ` Mingming Cao
2007-01-05 6:18 ` Amit K. Arora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m364bpn5ku.fsf@bzzz.home.net \
--to=alex@clusterfs.com \
--cc=aarora@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=suparna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).