From: "Jörg-Volker Peetz" <jvpeetz@web.de>
To: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: fix fencepost error in lazytime optimization
Date: Fri, 03 Jul 2015 14:35:41 +0200 [thread overview]
Message-ID: <mn5vit$6bh$1@ger.gmane.org> (raw)
In-Reply-To: <1435808288-20665-1-git-send-email-tytso@mit.edu>
Theodore Ts'o wrote on 07/02/2015 05:38:
> Commit 8f4d8558391: "ext4: fix lazytime optimization" was not a
> complete fix. In the case where the inode number is a multiple of 16,
> and we could still end up updating an inode with dirty timestamps
> written to the wrong inode on disk. Oops.
>
<snip>
> - ino = (orig_ino & ~(inodes_per_block - 1)) + 1;
> + ino = ((orig_ino - 1) & ~(inodes_per_block - 1)) + 1;
Maybe, a comment stating what should be accomplished here would help?
--
Regards,
Jörg.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-07-03 12:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 3:38 [PATCH] ext4: fix fencepost error in lazytime optimization Theodore Ts'o
2015-07-03 12:35 ` Jörg-Volker Peetz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='mn5vit$6bh$1@ger.gmane.org' \
--to=jvpeetz@web.de \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).