From: "Vitaliy Filippov" <vitalif@yourcmc.ru>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] misc: Use unsigned long long for file block count in filefrag
Date: Sun, 23 Feb 2014 20:28:53 +0400 [thread overview]
Message-ID: <op.xbqtefu20ncgu9@vitalif.vhome> (raw)
In-Reply-To: <20140223135834.GC2280@thunk.org>
> Hi Vitaliy,
>
> Thanks for the patch! Your patch is missing a Signed-Off-By footer.
> Also, you note that numblocks gets passed to filefrag_fibmap(), so if
> you're going to do this, and we fall back to using fibmap, you should
> probably check to see if numblocks would overflow an unsigned long,
> and if so, to give an error because fibmap ioctl only supports the use
> of a ulong.
OK, I've just resubmitted it :)
In fact, the block count was reported incorrectly for files bigger than
0xffffffff bytes, not blocks, because filefrag does (numblocks *
fsinfo.f_bsize >> blk_shift), and this overflows when numblocks is
32-bit...
--
With best regards,
Vitaliy Filippov
prev parent reply other threads:[~2014-02-23 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 9:08 [PATCH] misc: Use unsigned long long for file block count in filefrag Vitaliy Filippov
2014-02-23 13:58 ` Theodore Ts'o
2014-02-23 16:28 ` Vitaliy Filippov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.xbqtefu20ncgu9@vitalif.vhome \
--to=vitalif@yourcmc.ru \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox