From: jing zhang <zj.barak@gmail.com>
To: linux-ext4 <linux-ext4@vger.kernel.org>, "zj.barak" <zj.barak@gmail.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>, Andreas Dilger <adilger@sun.com>,
Dave Kleikamp <shaggy@linux.vnet.ibm.com>,
"Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [PATCH] ext4: group cache is added in ext4_mb_discard_preallocations()
Date: Tue, 30 Mar 2010 20:36:17 +0800 [thread overview]
Message-ID: <p2yac8f92701003300536kd52f7ad0p43755fcc2382423b@mail.gmail.com> (raw)
From: Jing Zhang <zj.barak@gmail.com>
Date: Tue Mar 30 20:35:22 2010
With the added cache, better group locality may be earned when
allocating blocks.
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Andreas Dilger <adilger@sun.com>
Cc: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Jing Zhang <zj.barak@gmail.com>
---
--- linux-2.6.32/fs/ext4/mballoc.c 2009-12-03 11:51:22.000000000 +0800
+++ ext4_mm_leak/mballoc-13.c 2010-03-30 20:28:08.000000000 +0800
@@ -4183,12 +4183,20 @@ static int ext4_mb_discard_preallocation
ext4_group_t i, ngroups = ext4_get_groups_count(sb);
int ret;
int freed = 0;
+ static ext4_group_t grp_cache = 0;
trace_ext4_mb_discard_preallocations(sb, needed);
- for (i = 0; i < ngroups && needed > 0; i++) {
- ret = ext4_mb_discard_group_preallocations(sb, i, needed);
+ if (needed <= 0)
+ return freed;
+ for (i = 0; i < ngroups; i++) {
+ if (grp_cache >= ngroups)
+ grp_cache -= ngroups;
+ ret = ext4_mb_discard_group_preallocations(sb, grp_cache, needed);
freed += ret;
needed -= ret;
+ if (needed <= 0)
+ break;
+ grp_cache++;
}
return freed;
next reply other threads:[~2010-03-30 12:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 12:36 jing zhang [this message]
2010-03-30 18:37 ` [PATCH] ext4: group cache is added in ext4_mb_discard_preallocations() Aneesh Kumar K. V
2010-03-31 15:10 ` jing zhang
2010-03-31 15:03 ` Andreas Dilger
2010-04-01 12:34 ` jing zhang
2010-04-06 18:49 ` tytso
2010-04-07 12:58 ` jing zhang
2010-04-07 14:46 ` tytso
2010-04-06 18:31 ` tytso
2010-04-07 12:50 ` jing zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p2yac8f92701003300536kd52f7ad0p43755fcc2382423b@mail.gmail.com \
--to=zj.barak@gmail.com \
--cc=adilger@sun.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=shaggy@linux.vnet.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).