From: sashiko-bot@kernel.org
To: guolingxing <guolingxing@tju.edu.cn>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/3] jbd2: check return value of blkdev_issue_flush() when checkpointing
Date: Mon, 12 Oct 2026 12:03:54 +0000 [thread overview]
Message-ID: <sashiko-outbox-168056@kernel.org> (raw)
In-Reply-To: <20261012114713.4049391-1-guolingxing@tju.edu.cn>
> jbd2_cleanup_journal_tail() calls blkdev_issue_flush() on the file
> system device to make sure all checkpointed data are on permanent
> storage before it updates the log tail in the superblock. However
> the return value of blkdev_issue_flush() is ignored so if the flush
> fails, we still advance the log tail. After a crash the journal
> recovery will consider the checkpointed transactions as committed
> and skip the replay while their data may have never reached the
> disk, which may lead to a filesystem corruption.
>
> Abort the journal when the flush fails, similar to how we abort
> when detecting writeback errors of the file system device.
>
> Fixes: 79feb521a447 ("jbd2: issue cache flush after checkpointing even with internal journal")
> Cc: stable@vger.kernel.org
> Signed-off-by: guolingxing <guolingxing@tju.edu.cn>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261012114713.4049391-1-guolingxing@tju.edu.cn?part=1
next prev parent reply other threads:[~2026-10-12 12:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 11:47 [PATCH 1/3] jbd2: check return value of blkdev_issue_flush() when checkpointing guolingxing
2026-10-12 11:47 ` [PATCH 2/3] jbd2: check return value of blkdev_issue_flush() when committing guolingxing
2026-10-12 12:10 ` sashiko-bot
2026-10-12 15:31 ` Jan Kara
2026-10-12 11:47 ` [PATCH 3/3] jbd2: check return value of blkdev_issue_flush() for async commits guolingxing
2026-10-12 12:16 ` sashiko-bot
2026-10-12 15:33 ` Jan Kara
2026-10-12 12:03 ` sashiko-bot [this message]
2026-10-12 15:29 ` [PATCH 1/3] jbd2: check return value of blkdev_issue_flush() when checkpointing Jan Kara
2026-10-13 1:40 ` [PATCH v2 0/3] jbd2: check return value of blkdev_issue_flush() guolingxing
2026-10-13 1:40 ` [PATCH v2 1/3] jbd2: check return value of blkdev_issue_flush() when checkpointing guolingxing
2026-10-13 1:50 ` sashiko-bot
2026-10-13 1:40 ` [PATCH v2 2/3] jbd2: check return value of blkdev_issue_flush() when committing guolingxing
2026-10-13 1:48 ` sashiko-bot
2026-10-13 1:40 ` [PATCH v2 3/3] jbd2: check return value of blkdev_issue_flush() for async commits guolingxing
2026-10-13 1:49 ` sashiko-bot
2026-10-13 12:20 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-168056@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=guolingxing@tju.edu.cn \
--cc=linux-ext4@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox