Re: [PATCH] ext4: spread files of sibling directories over a flex group

[sashiko-bot@kernel.org]

> From: Daejun Park <daejun7.park@samsung.com>
> 
> On a flex_bg file system, find_group_other() puts a new file in the
> first group of the parent's flex group that has a free inode. Orlov
> usually keeps a directory below the top level in its parent's flex group
> and packs directory inodes at its start, so the files of sibling
> directories come from the same group and get consecutive inode numbers.
> The flex_bg path was added by commit a4912123b688 ("ext4: New
> inode/block allocation algorithms for flex_bg filesystems"). The
> non-flex_bg path instead adds the parent's inode number to the starting
> group once the parent's own group has no free inode or block, so that
> the files of different directories which share a group land in
> different groups.
> 
> When several tasks create files in sibling directories at the same time,
> [ ... ]
> retry only with a group below the number of groups.
> 
> Update the description in Documentation/filesystems/ext4/allocators.rst.
> 
> Signed-off-by: Daejun Park <daejun7.park@samsung.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013-ialloc-flex-spread-v1-1-9ea1d86961aa@samsung.com?part=1