Re: [PATCH] ext4: return 0 instead of stale ret in ext4_iomap_writepages()

[sashiko-bot@kernel.org]

> From: Zhang Yi <yi.zhang@huawei.com>
> 
> smatch reports a "missing error code" warning:
> 
>   fs/ext4/inode.c:4518 ext4_iomap_writepages() warn: missing error code? 'ret'
> 
> The 'ret' variable has already been consumed by the ext4_emergency_state()
> check at the beginning of the function, so its value is always zero at this
> point.  Returning it is equivalent to returning 0, but it is misleading
> because it looks like an error code is being propagated.
> 
> This branch handles the race with ext4_change_inode_journal_flag(), which
> flushes the dirty data and drops the page cache before switching the inode
> to the buffer_head path, so there is genuinely nothing to write back here.
> Return 0 explicitly to make the intent clear.
> 
> Fixes: bdcbb0f19e92 ("ext4: partially enable iomap for the buffered I/O path of regular files")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Closes: https://lore.kernel.org/r/202610160314.PLMEXaOJ-lkp@intel.com/
> Signed-off-by: Zhang Yi <yi.zhang@huawei.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016095927.1762656-1-yi.zhang@huaweicloud.com?part=1