Re: [PATCH] ext2: only flush DIRSYNC directories on every change

[sashiko-bot@kernel.org]

> Every change of an ext2 directory is written to disk before the system call
> returns, whether the directory is DIRSYNC or not: its pages with
> filemap_write_and_wait() and its inode with sync_inode_metadata().
> 
> Writes which reach the device for 2000 files, and 200 directories, in a
> directory without DIRSYNC, with the flusher turned off:
> 
>             create   rename   unlink   mkdir
>     before    4000     8000     4000     800
>     after        0        0        0       0
> 
> In a directory with chattr +D the numbers are those of "before", before and
> after.
> 
> commit bc943f4872a7 ("ext2: Don't flush page immediately for DIRSYNC
> directories") moved the flush from ext2_commit_chunk() to the new
> ext2_handle_dirsync().  The IS_DIRSYNC() check which was around it didn't
> move along.
> 
> Fix by putting the check into ext2_handle_dirsync().
> 
> Fixes: bc943f4872a7 ("ext2: Don't flush page immediately for DIRSYNC directories")
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261027-b4-ext2-dirsync-v1-1-3dcd012d518d@toxicpanda.com?part=1