Linux EXT4 FS development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Elliot Berman" <elliotjb@elliotjb.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH 6.1.y 2/2] bs/ntfs3: fix NULL folio dereference in ntfs_lock_new_page()
Date: Mon, 02 Nov 2026 14:40:50 +0000	[thread overview]
Message-ID: <sashiko-outbox-193593@kernel.org> (raw)
In-Reply-To: <20261102-ext4-ntfs3-null-folio-v1-2-4fd91ee23a4a@elliotjb.com>

> In 6.1, __filemap_get_folio() returns NULL on failure.  The backport of
> commit 95b917a14b15 ("ntfs: Do not overwrite uptodate pages") keeps the
> original IS_ERR() check, which is always false here, so a failed folio
> allocation while reading a compressed file dereferences NULL in
> folio_test_uptodate(). Check for NULL and return ERR_PTR(-ENOMEM).
> 
> Fixes: 95b917a14b15 ("ntfs: Do not overwrite uptodate pages")
> Signed-off-by: Elliot Berman <elliotjb@elliotjb.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-ext4-ntfs3-null-folio-v1-0-4fd91ee23a4a@elliotjb.com?part=2


  reply	other threads:[~2026-11-02 14:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 14:37 [PATCH 6.1.y 0/2] Fix NULL folio dereferences from IS_ERR() checks in 6.1.191 Elliot Berman
2026-11-02 14:37 ` [PATCH 6.1.y 1/2] ext4: fix NULL folio dereference in mballoc Elliot Berman
2026-11-02 14:42   ` sashiko-bot
2026-11-02 14:37 ` [PATCH 6.1.y 2/2] bs/ntfs3: fix NULL folio dereference in ntfs_lock_new_page() Elliot Berman
2026-11-02 14:40   ` sashiko-bot [this message]
2026-11-02 17:22 ` [PATCH 6.1.y 0/2] Fix NULL folio dereferences from IS_ERR() checks in 6.1.191 Naman Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-193593@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=elliotjb@elliotjb.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox