From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793717292; b=FTyXEirN4TfODEhVEQ2RM14DpJYucYiNDcTOa7bGI6E1xOs2MwiI2Gn2KNlJmrj2UzOv K++BOt1h5fste6vUU1hyHNUBOASiXWE2BL4Qr4CQiC6IH/WMzVFIJHMsfsG/lAXJ4GN6D 5z4uh5vauPa41B2wqPjn4wFrTkXq4lfvI2dW1JTCQWyA3pCHpCFkv+0/SF5h6yZFzvfTF pSxSFfjmKGdGd/WQdadIu3dVHXk1KdJsjlzBKdc979uIfuKspYs5yOwuEOEcCJ4b0vjzt QDOlIRvzCnAClxVSrfKmF4EKfgOPbkOrl0JUN3thLmvtmxuUOu9yL9SKfgvgJaUzIgg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793717292; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=IjXeEs0cvKJ9BEkMWj983otFpIRGB9/uiTG6eTej6SY=; b=Lw5jFglz3APSIpRKX7qufPjNlyZ0gWBlycwTqoUF9lyGLaxHq5GdrZo/xhVA1c5aoRVp vVcLYImG+ESJBCBk4/UdeC3uTvK/4NSXTA9ri5KOA263FNRvziLj1a++RTmDtolcUWu0Y BwyuGOdxPyBh8xuT1XvWLgJd+vO9OgEOnLP25Vzky7j7cK/jRMdTSVTIqIEw/MMTTac3m qO7pb9dwgQzN7Fb1Ccs47IXxbQAprS9uVW6gBkuEgvUiT7rb4dZQOR1qprdrBg9Nh0hg8 pGrIWhnXt2CHmAui0bnix9wFIAA6iQbDC7SGdq51h3obe6rm0du0jKDCFzZYyeZ4D9w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KNzIAkDc; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB3A160A5BEB; Tue, 3 Nov 2026 14:48:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KNzIAkDc Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EA6E1F00919; Tue, 3 Nov 2026 14:48:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793717291; bh=IjXeEs0cvKJ9BEkMWj983otFpIRGB9/uiTG6eTej6SY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=KNzIAkDcTAyZi+bMDBEDiJ2ueX6+YuNBqQcpX4aSHRAYfT+9O1WnTJ+pT4zRQBBHX p25i441sJ/pPELfnxtK22X3a1lcSIwpcUY38RMAWCOPurdhPZg+7wIe+xltR5RL31U u481RToVHFbarFTlUWzAE9MGCxYh1xelMTlElM9jsoGQWFc05EGBAhMboLFT0D6o3c ZdwQlbqPOxICYuQsuQoNiBroU5anKaeSmXCKUvubsHl3FSv4AlbNXkVjqgO6mUx1pR swIa23i3wGX82qen6c30FEla74FnYQVAcQdkulRdqS/OXs8CaHc0ie+cdiYQ5eL3YC V7rdW/Ghfh0qg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RFC 22/38] proc: warn about entries left in /proc/net of a dying namespace Reply-To: sashiko-reviews@lists.linux.dev To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-ext4@vger.kernel.org, "Chuck Lever" , tytso@mit.edu, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261102-work-procfs-bugfixes-v1-22-59422ed3e465@kernel.org> References: <20261102-work-procfs-bugfixes-v1-0-59422ed3e465@kernel.org> <20261102-work-procfs-bugfixes-v1-22-59422ed3e465@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 03 Nov 2026 14:48:09 +0000 X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list > proc_net_ns_exit() runs after all the other pernet exits and frees > net->proc_net right after removing "stat" from it. An entry that some > pernet exit forgot to remove is left with a freed ->parent, and so > PDE_NET() hands seq_open_net() and single_open_net() a freed struct net > when the entry is opened through a file descriptor that someone kept. >=20 > There is no such entry in the tree that we know of, but nothing would > tell us about one either. So warn about it like remove_proc_entry() > does for a directory that isn't empty. >=20 > Reported-by: Chris Mason > Fixes: e9720acd728a ("[NET]: Make /proc/net a symlink on /proc/self/net (= v3)") > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261102-work-procf= s-bugfixes-v1-0-59422ed3e465@kernel.org?part=3D22