From: sashiko-bot@kernel.org
To: "Amit Patole" <amit.patole@gmail.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] jbd2: document the h_invalid handle flag
Date: Thu, 05 Nov 2026 15:58:31 +0000 [thread overview]
Message-ID: <sashiko-outbox-199389@kernel.org> (raw)
In-Reply-To: <20261105-kdoc-jbd2-h_invalid-v1-1-4bc224f7d0a2@gmail.com>
> Commit 61e2a90a910c ("ext4: enable scoped NOFS when starting a handle
> in nojournal mode") added the h_invalid bit to struct
> jbd2_journal_handle but did not add it to the kernel-doc comment above
> the structure, so kernel-doc now warns:
>
> include/linux/jbd2.h:523 struct member 'h_invalid' not described in
> 'jbd2_journal_handle'
>
> Describe the new flag. It is set by ext4_get_nojournal() on a handle
> that is not attached to any journal and is tested by
> ext4_handle_valid().
>
> The warning was found by running scripts/kernel-doc over the headers
> pulled into the htmldocs build. An AI coding assistant (Claude Opus
> 5.5) was used to locate the warning and draft this change; it was
> verified with scripts/kernel-doc (no warnings left) and checkpatch.
>
> Fixes: 61e2a90a910c ("ext4: enable scoped NOFS when starting a handle in nojournal mode")
> Signed-off-by: Amit Patole <amit.patole@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-kdoc-jbd2-h_invalid-v1-1-4bc224f7d0a2@gmail.com?part=1
prev parent reply other threads:[~2026-11-05 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 14:00 [PATCH] jbd2: document the h_invalid handle flag Amit Patole
2026-11-05 15:58 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-199389@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=amit.patole@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox