Re: [PATCH] ext4: make concurrent DEFAULT shutdown waits killable

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] block: missing Signed-off-by trailer and real author name in
  commit
- [Medium] block: commit message is a raw ext4 email reply with wrong
  bdev_freeze() info
--

commit b7fc68757e7a71c50d74a009f283890518f74c9a
Author: diasyzhangqing@gmail.com <diasyzhangqing@gmail.com>

> ext4: make concurrent DEFAULT shutdown waits killable
>
> On Tue 10-11-26 21:35:56, Jan Kara wrote:
> > Err, no. This is really syzkaller self-inflicted damage we aren't going to
> > work around. If anything you could make the wait on bd_fsfreeze_mutex
> > in bdev_freeze() killable. That will actually be a sensible change and
> > should address syzbot warning as well.
>
> Thanks, that's indeed simpler.  All current callers of bdev_freeze()
> (the generic FIFREEZE ioctl, ext4, ntfs, ntfs3, xfs) already propagate
> the error, so only the wait itself needs to change:

[Severity: High]
This commit is missing a Signed-off-by: trailer, and the Author header uses
an email address instead of the author's real name.

[Severity: Medium]
Does the commit title and message match the change being made?

The patch modifies bdev_freeze() in block/bdev.c rather than ext4, and the
changelog is formatted as an email reply rather than a standalone commit
description.  In addition, ioctl_fsfreeze() calls freeze_super() rather than
bdev_freeze(), other callers exist (lock_fs(), exfat_force_shutdown(), and
f2fs_do_shutdown()), and xfs_fs_goingdown() ignores non-zero returns from
bdev_freeze() and returns 0 without calling xfs_force_shutdown().

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111032743.549426-1-diasyzhangqing@gmail.com?part=1