Re: [PATCH v3 33/33] xfs: allow remounting read-only after a shutdown

[sashiko-bot@kernel.org]

> xfs_remount_ro() starts with sync_filesystem() which fails with EIO
> after a shutdown. So a shut down xfs can't be remounted read-only and
> emergency remount (sysrq u) WARNs in reconfigure_super(), a panic with
> panic_on_warn:
> 
>   forced remount of a xfs fs returned -5
> 
> Going read-only doesn't need to write anything. So ignore the errors
> from flushing and from freeing the COW and post-EOF blocks once xfs is
> shut down, also if the flush shut it down itself. The rest of
> xfs_remount_ro() copes with a shutdown like unmount does. And refuse
> going back to read-write with EIO, xfs_remount_rw() didn't check for a
> shutdown at all.
> 
> Fixes: b97cca3ba909 ("xfs: only bother with sync_filesystem during readonly remount")
> Cc: stable@vger.kernel.org
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-work-fs-sb_rdonly-v3-0-0be92bb73709@kernel.org?part=33