Re: [PATCH 02/12] docs: ioctl-number: update sound entries

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 5 potential
issues to consider:
- [Low] docs: ioctl-number: wrong code, range, and conflict marker for
  scarlett2.h
- [Low] docs: ioctl-number: incomplete sequence range for sound/pcm.h
- [Low] docs: ioctl-number: incomplete range and tab char for
  sound/core/pcm_compat.c
- [Low] docs: ioctl-number: incomplete sequence range for
  sound/core/seq/seq_compat.c
- [Low] docs: ioctl-number: missing conflict! marker on switchtec.c
  under code 'W'
--

commit 0316dc2cd0f479a35471758d208f4335b8fbc617
Author: Randy Dunlap <rdunlap@infradead.org>

docs: ioctl-number: update sound entries

This commit updates the ioctl-number documentation table with additional
sound header and compat files and adjusts sequence number ranges for sound
ioctls.

> diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst
> index e1d56d5cccd14..dac65f59d05e2 100644
> --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
> +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
> @@ -122,11 +122,14 @@ Code  Seq#    Include File                                             Comments
>  'A'   00-0F  linux/agpgart.h,                                          conflict!
>               drivers/char/agp/compat_ioctl.h
>  'A'   00-7F  sound/asound.h                                            conflict!
> +'A'   20     sound/pcm.h                                               conflict!

[Severity: Low]
Should the sequence range for sound/pcm.h be 20-24 instead of 20?  In
include/sound/pcm.h, SNDRV_PCM_IOCTL_STATUS_EXT64 and
SNDRV_PCM_IOCTL_STATUS_EXT32 also define ioctls using _IOWR('A', 0x24, ...).

> +'A'   20-53  sound/core/pcm_compat.c	                               conflict!

[Severity: Low]
Should the sequence range for sound/core/pcm_compat.c start at 10 rather
than 20?  The compat ioctl enum in sound/core/pcm_compat.c starts with
SNDRV_PCM_IOCTL_HW_REFINE32 (_IOWR('A', 0x10, ...)),
SNDRV_PCM_IOCTL_HW_PARAMS32 (0x11), and SNDRV_PCM_IOCTL_SW_PARAMS32 (0x13).
Also, there is a literal tab character right after sound/core/pcm_compat.c
instead of spaces.

[ ... ]

> @@ -160,7 +164,9 @@ Code  Seq#    Include File                                             Comments
>  'H'   10-1F  sound/hda_hwdep.h                                         conflict!
>  'H'   40-4F  sound/hdspm.h                                             conflict!
>  'H'   40-4F  sound/hdsp.h                                              conflict!
> +'H'   60-63  sound/scarlett2.h

[Severity: Low]
Should sound/scarlett2.h be listed under code 'S' with range 60-64 and a
conflict! marker instead of 'H' 60-63?  In include/uapi/sound/scarlett2.h,
all ioctls use code 'S' from SCARLETT2_IOCTL_PVERSION (_IOR('S', 0x60, int))
through SCARLETT2_IOCTL_GET_ERASE_PROGRESS (_IOR('S', 0x64, ...)), which
overlaps with linux/cdrom.h, sound/asequencer.h, and sound/fcp.h.

[ ... ]

> @@ -204,6 +210,8 @@ Code  Seq#    Include File                                             Comments
>  'S'   80-81  scsi/scsi_ioctl.h                                         conflict!
>  'S'   82-FF  scsi/scsi.h                                               conflict!
>  'S'   00-7F  sound/asequencer.h                                        conflict!
> +'S'   21-23  sound/core/seq/seq_compat.c                               conflict!

[Severity: Low]
Should the sequence range for sound/core/seq/seq_compat.c be 20-52 instead
of 21-23?  That file also defines SNDRV_SEQ_IOCTL_CREATE_PORT32
(_IOWR('S', 0x20, ...)) and SNDRV_SEQ_IOCTL_QUERY_NEXT_PORT32
(_IOWR('S', 0x52, ...)).

[ ... ]

> @@ -219,7 +227,7 @@ Code  Seq#    Include File                                             Comments
>  'V'   C0     media/si4713.h                                            conflict!
>  'W'   00-1F  linux/watchdog.h                                          conflict!
>  'W'   00-1F  linux/wanrouter.h                                         conflict! (pre 3.9)
> -'W'   00-3F  sound/asound.h                                            conflict!
> +'W'   00-41  sound/asound.h                                            conflict!
>  'W'   40-5F  drivers/pci/switch/switchtec.c

[Severity: Low]
Does the drivers/pci/switch/switchtec.c entry now need a conflict! marker
as well, since extending sound/asound.h to 00-41 causes the two ranges to
overlap on 40-41?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114202653.3113381-1-rdunlap@infradead.org?part=2