* [PATCH] jbd2: Remove unused t_handle_lock
@ 2023-07-26 15:23 Wang Jianjian
2023-07-31 9:19 ` Ritesh Harjani
0 siblings, 1 reply; 7+ messages in thread
From: Wang Jianjian @ 2023-07-26 15:23 UTC (permalink / raw)
To: linux-ext4; +Cc: wangjianjian0
Since commit f7f497cb7024 ("jbd2: kill t_handle_lock
transaction spinlock"), this lock has been no use.
Signed-off-by: Wang Jianjian <wangjianjian0@foxmail.com>
---
include/linux/jbd2.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
index d860499e15e4..8199235dbaf3 100644
--- a/include/linux/jbd2.h
+++ b/include/linux/jbd2.h
@@ -636,11 +636,6 @@ struct transaction_s
*/
struct list_head t_inode_list;
- /*
- * Protects info related to handles
- */
- spinlock_t t_handle_lock;
-
/*
* Longest time some handle had to wait for running transaction
*/
--
2.34.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] jbd2: Remove unused t_handle_lock
@ 2023-08-02 14:45 Wang Jianjian
2023-08-05 12:20 ` Theodore Ts'o
0 siblings, 1 reply; 7+ messages in thread
From: Wang Jianjian @ 2023-08-02 14:45 UTC (permalink / raw)
To: linux-ext4; +Cc: wangjianjian0, Ritesh Harjani
Since commit f7f497cb7024 ("jbd2: kill t_handle_lock
transaction spinlock"), this lock has been no use.
Fixes: f7f497cb7024 ("jbd2: kill t_handle_lock transaction spinlock")
Signed-off-by: Wang Jianjian <wangjianjian0@foxmail.com>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
---
include/linux/jbd2.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
index d860499e15e4..8199235dbaf3 100644
--- a/include/linux/jbd2.h
+++ b/include/linux/jbd2.h
@@ -636,11 +636,6 @@ struct transaction_s
*/
struct list_head t_inode_list;
- /*
- * Protects info related to handles
- */
- spinlock_t t_handle_lock;
-
/*
* Longest time some handle had to wait for running transaction
*/
--
2.34.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] jbd2: Remove unused t_handle_lock
2023-08-02 14:45 Wang Jianjian
@ 2023-08-05 12:20 ` Theodore Ts'o
0 siblings, 0 replies; 7+ messages in thread
From: Theodore Ts'o @ 2023-08-05 12:20 UTC (permalink / raw)
To: linux-ext4, Wang Jianjian; +Cc: Theodore Ts'o, Ritesh Harjani
On Wed, 02 Aug 2023 22:45:34 +0800, Wang Jianjian wrote:
> Since commit f7f497cb7024 ("jbd2: kill t_handle_lock
> transaction spinlock"), this lock has been no use.
>
>
Applied, thanks!
[1/1] jbd2: Remove unused t_handle_lock
commit: e15e117bbbe18258a5ad506bbf6c58ff129c9576
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] jbd2: Remove unused t_handle_lock
@ 2023-07-24 14:58 Wang Jianjian
2023-07-26 11:19 ` Zhang Yi
0 siblings, 1 reply; 7+ messages in thread
From: Wang Jianjian @ 2023-07-24 14:58 UTC (permalink / raw)
To: linux-ext4; +Cc: wangjianjian0
Since commit 4f98186848('jbd2: refactor wait logic for transaction
updates into a common function'), this lock has been no use.
---
include/linux/jbd2.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
index d860499e15e4..8199235dbaf3 100644
--- a/include/linux/jbd2.h
+++ b/include/linux/jbd2.h
@@ -636,11 +636,6 @@ struct transaction_s
*/
struct list_head t_inode_list;
- /*
- * Protects info related to handles
- */
- spinlock_t t_handle_lock;
-
/*
* Longest time some handle had to wait for running transaction
*/
--
2.34.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] jbd2: Remove unused t_handle_lock
2023-07-24 14:58 Wang Jianjian
@ 2023-07-26 11:19 ` Zhang Yi
0 siblings, 0 replies; 7+ messages in thread
From: Zhang Yi @ 2023-07-26 11:19 UTC (permalink / raw)
To: Wang Jianjian, linux-ext4
On 2023/7/24 22:58, Wang Jianjian wrote:
> Since commit 4f98186848('jbd2: refactor wait logic for transaction
> updates into a common function'), this lock has been no use.
Hi, I don't think the commit is correct, it should be
f7f497cb7024 ("jbd2: kill t_handle_lock transaction spinlock").
Thanks,
Yi.
> ---
> include/linux/jbd2.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index d860499e15e4..8199235dbaf3 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -636,11 +636,6 @@ struct transaction_s
> */
> struct list_head t_inode_list;
>
> - /*
> - * Protects info related to handles
> - */
> - spinlock_t t_handle_lock;
> -
> /*
> * Longest time some handle had to wait for running transaction
> */
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-08-05 12:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-26 15:23 [PATCH] jbd2: Remove unused t_handle_lock Wang Jianjian
2023-07-31 9:19 ` Ritesh Harjani
2023-08-02 14:46 ` Wang Jianjian
-- strict thread matches above, loose matches on Subject: below --
2023-08-02 14:45 Wang Jianjian
2023-08-05 12:20 ` Theodore Ts'o
2023-07-24 14:58 Wang Jianjian
2023-07-26 11:19 ` Zhang Yi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).