From: Chao Yu <chao2.yu@samsung.com>
To: jaegeuk.kim@samsung.com
Cc: linux-fsdevel@vger.kernel.org, '谭姝' <shu.tan@samsung.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: [PATCH V2] f2fs: check all ones or zeros bitmap with bitops for better mount performance
Date: Thu, 24 Oct 2013 16:21:28 +0800 [thread overview]
Message-ID: <000401ced092$28087a90$78196fb0$@samsung.com> (raw)
Previously, check_block_count check valid_map with bit data type in common scenario that sit has all ones or zeros bitmap, it makes low mount performance.
So let's check the special bitmap with integer data type instead of the bit one.
v2:
use find_next_bit_le/find_next_zero_bit_le for better performance and readable as Jaegeuk suggested.
Suggested-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Signed-off-by: Tan Shu <shu.tan@samsung.com>
Signed-off-by: Yu Chao <chao2.yu@samsung.com>
---
fs/f2fs/segment.h | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
index 7f94d78..d25b6af 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -552,6 +552,23 @@ static inline void check_block_count(struct f2fs_sb_info *sbi,
/* check boundary of a given segment number */
BUG_ON(segno > end_segno);
+ /* check all ones or zeros valid_map */
+ if (GET_SIT_VBLOCKS(raw_sit) == 0) {
+ int pos = find_next_bit_le(&raw_sit->valid_map,
+ sbi->blocks_per_seg,
+ 0);
+ if (pos != sbi->blocks_per_seg)
+ BUG();
+ return;
+ } else if (GET_SIT_VBLOCKS(raw_sit) == sbi->blocks_per_seg) {
+ int pos = find_next_zero_bit_le(&raw_sit->valid_map,
+ sbi->blocks_per_seg,
+ 0);
+ if (pos != sbi->blocks_per_seg)
+ BUG();
+ return;
+ }
+
/* check bitmap with valid block count */
for (i = 0; i < sbi->blocks_per_seg; i++)
if (f2fs_test_bit(i, raw_sit->valid_map))
--
1.7.9.5
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
next reply other threads:[~2013-10-24 8:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 8:21 Chao Yu [this message]
2013-10-24 10:03 ` [f2fs-dev] [PATCH V2] f2fs: check all ones or zeros bitmap with bitops for better mount performance Gu Zheng
2013-10-25 1:34 ` Chao Yu
2013-10-28 2:19 ` 이창만
2013-10-28 2:30 ` Gu Zheng
2013-10-28 7:07 ` [f2fs-dev] " Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000401ced092$28087a90$78196fb0$@samsung.com' \
--to=chao2.yu@samsung.com \
--cc=jaegeuk.kim@samsung.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shu.tan@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).