From: Fan Li <fanofcode.li@samsung.com>
To: jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: [PATCH] f2fs: Change the timing of f2fs_wait_on_page_writeback
Date: Tue, 04 Aug 2015 13:27:51 +0800 [thread overview]
Message-ID: <000901d0ce76$64916f60$2db44e20$@samsung.com> (raw)
some backing devices need pages to be stable during writeback. It doesn't
matter if
the page is completely overwritten or already uptodate, it needs to wait
before write.
Signed-off-by: Fan li <fanofcode.li@samsung.com>
---
fs/f2fs/data.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 57042bd..364840f 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1386,13 +1386,13 @@ put_next:
f2fs_put_dnode(&dn);
f2fs_unlock_op(sbi);
+ f2fs_wait_on_page_writeback(page, DATA);
+
if (len == PAGE_CACHE_SIZE)
goto out_update;
if (PageUptodate(page))
goto out_clear;
- f2fs_wait_on_page_writeback(page, DATA);
-
if ((pos & PAGE_CACHE_MASK) >= i_size_read(inode)) {
unsigned start = pos & (PAGE_CACHE_SIZE - 1);
unsigned end = start + len;
--
1.7.9.5
------------------------------------------------------------------------------
next reply other threads:[~2015-08-04 5:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 5:27 Fan Li [this message]
2015-08-04 10:00 ` [PATCH] f2fs: Change the timing of f2fs_wait_on_page_writeback Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000901d0ce76$64916f60$2db44e20$@samsung.com' \
--to=fanofcode.li@samsung.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).