* [f2fs-dev] [PATCH] f2fs: use unlikely for release case [not found] <CGME20171205083900epcas5p3da0ba06455bf7f17ffacd0b25328aca3@epcas5p3.samsung.com> @ 2017-12-05 8:38 ` LiFan 2017-12-11 13:16 ` Chao Yu 0 siblings, 1 reply; 2+ messages in thread From: LiFan @ 2017-12-05 8:38 UTC (permalink / raw) To: 'Chao Yu', 'Chao Yu', 'Jaegeuk Kim' Cc: linux-kernel, linux-f2fs-devel Since the variable release is only nonzero when another unlikely case occurs, use unlikely() on it seems logical. Signed-off-by: Fan li <fanofcode.li@samsung.com> --- fs/f2fs/f2fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 71fbba96..0f01af0 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -1594,7 +1594,7 @@ static inline int inc_valid_block_count(struct f2fs_sb_info *sbi, } spin_unlock(&sbi->stat_lock); - if (release) + if (unlikely(release)) dquot_release_reservation_block(inode, release); f2fs_i_blocks_write(inode, *count, true, true); return 0; -- 2.7.4 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] f2fs: use unlikely for release case 2017-12-05 8:38 ` [f2fs-dev] [PATCH] f2fs: use unlikely for release case LiFan @ 2017-12-11 13:16 ` Chao Yu 0 siblings, 0 replies; 2+ messages in thread From: Chao Yu @ 2017-12-11 13:16 UTC (permalink / raw) To: LiFan, 'Chao Yu', 'Jaegeuk Kim' Cc: linux-kernel, linux-f2fs-devel On 2017/12/5 16:38, LiFan wrote: > Since the variable release is only nonzero when another unlikely > case occurs, use unlikely() on it seems logical. > > Signed-off-by: Fan li <fanofcode.li@samsung.com> Reviewed-by: Chao Yu <yuchao0@huawei.com> Thanks, ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-11 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20171205083900epcas5p3da0ba06455bf7f17ffacd0b25328aca3@epcas5p3.samsung.com>
2017-12-05 8:38 ` [f2fs-dev] [PATCH] f2fs: use unlikely for release case LiFan
2017-12-11 13:16 ` Chao Yu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).