Linux-f2fs-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Fan Li <fanofcode.li@samsung.com>
To: 'Jaegeuk Kim' <jaegeuk@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: [PATCH 2/3] f2fs: support finding extents after isize
Date: Wed, 30 Dec 2015 17:17:23 +0800	[thread overview]
Message-ID: <000d01d142e2$fab05fc0$f0111f40$@samsung.com> (raw)

f2fs allows preallocation beyond isize, but f2fs_fiemap only look up
extents within isize. Therefore add this support.

Note: It's possible that there are holes after isize, for example,
fallocate  multiple discontinuous extents after isize with 
FALLOC_FL_KEEP_SIZE set. Since I can tell no differences between 
EOF and holes from return of get_data_block, I'm afaid this patch
can't support such scenarios. 


Signed-off-by: Fan li <fanofcode.li@samsung.com>
---
 fs/f2fs/data.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index a9a4d89..f89cf07 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -798,12 +798,6 @@ int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,
 	isize = i_size_read(inode);
 
 	mutex_lock(&inode->i_mutex);
-	if (start >= isize)
-		goto out;
-
-	if (start + len > isize)
-		len = isize - start;
-
 	if (logical_to_blk(inode, len) == 0)
 		len = blk_to_logical(inode, 1);
 
@@ -829,6 +823,7 @@ next:
 		 * punch holes beyond isize and keep size unchanged.
 		 */
 		flags |= FIEMAP_EXTENT_LAST;
+		last_blk = start_blk - 1;
 	}
 
 	if (size)
-- 
1.7.9.5


------------------------------------------------------------------------------

             reply	other threads:[~2015-12-30  9:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-30  9:17 Fan Li [this message]
2015-12-30 13:27 ` [PATCH 2/3] f2fs: support finding extents after isize Chao Yu
2015-12-31  3:37   ` Fan Li
2015-12-31  6:34     ` Chao Yu
2016-01-04  5:57       ` Fan Li
2016-01-04  6:55         ` Jaegeuk Kim
2016-01-04 11:13           ` Fan Li
2016-01-04 23:14             ` Jaegeuk Kim
2016-01-05  2:37               ` Fan Li
2016-01-05  3:08                 ` Jaegeuk Kim
2016-01-05  7:22                   ` Fan Li
2016-01-05 18:11                     ` Jaegeuk Kim
2016-01-05  3:19           ` Chao Yu
2016-01-05  3:29             ` Jaegeuk Kim
2016-01-05  9:36               ` Chao Yu
2016-01-04 10:00         ` Chao Yu
2016-01-04 10:55           ` Fan Li
2016-01-05  3:48             ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000d01d142e2$fab05fc0$f0111f40$@samsung.com' \
    --to=fanofcode.li@samsung.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox