From: Chao Yu <chao2.yu@samsung.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Changman Lee <cm224.lee@samsung.com>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [f2fs-dev][PATCH 1/4] f2fs: fix to enable readahead for SSA/CP blocks
Date: Mon, 08 Dec 2014 14:56:19 +0800 [thread overview]
Message-ID: <001801d012b4$2ffb5c80$8ff21580$@samsung.com> (raw)
1.We use zero as upper boundary value for ra SSA/CP blocks, we will skip
readahead as verification failure with max number, it causes low performance.
2.Low boundary value is not accurate for SSA/CP/POR region verification, so
these values need to be redefined.
This patch fixes above issues.
Signed-off-by: Chao Yu <chao2.yu@samsung.com>
---
fs/f2fs/checkpoint.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index 20a917b..c32ed7c 100644
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -95,8 +95,9 @@ static inline block_t get_max_meta_blks(struct f2fs_sb_info *sbi, int type)
case META_SIT:
return SIT_BLK_CNT(sbi);
case META_SSA:
+ return MAIN_BLKADDR(sbi);
case META_CP:
- return 0;
+ return SM_I(sbi)->sit_info->sit_base_addr;
case META_POR:
return MAX_BLKADDR(sbi);
default:
@@ -141,11 +142,23 @@ int ra_meta_pages(struct f2fs_sb_info *sbi, block_t start, int nrpages, int type
prev_blk_addr = blk_addr;
break;
case META_SSA:
+ if (unlikely(blkno >= max_blks))
+ goto out;
+ if (unlikely(blkno < SM_I(sbi)->ssa_blkaddr))
+ goto out;
+ blk_addr = blkno;
+ break;
case META_CP:
+ if (unlikely(blkno >= max_blks))
+ goto out;
+ if (unlikely(blkno < __start_cp_addr(sbi)))
+ goto out;
+ blk_addr = blkno;
+ break;
case META_POR:
if (unlikely(blkno >= max_blks))
goto out;
- if (unlikely(blkno < SEG0_BLKADDR(sbi)))
+ if (unlikely(blkno < MAIN_BLKADDR(sbi)))
goto out;
blk_addr = blkno;
break;
--
2.1.2
reply other threads:[~2014-12-08 6:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001801d012b4$2ffb5c80$8ff21580$@samsung.com' \
--to=chao2.yu@samsung.com \
--cc=cm224.lee@samsung.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).