From: <changfengnan@vivo.com>
To: "'Jaegeuk Kim'" <jaegeuk@kernel.org>,
"'Fengnan Chang'" <fengnanchang@gmail.com>
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] 答复: 答复: [RFC PATCH] f2fs: add no compress extensions support
Date: Tue, 20 Apr 2021 10:08:00 +0800 [thread overview]
Message-ID: <003b01d73589$fd640060$f82c0120$@vivo.com> (raw)
In-Reply-To: <YH2uYPmJBvZFqIz+@google.com>
It seems that we don't need to support * for non-compress.
For now, if one file match comp_extention, the dir flag not work, but we can still use comp_file_flag and no_comp_file_flag. So the priority is:
dir_flag < comp_extention < comp_file_flag, no_comp_file_flag.
after add no_comp_extention flag, the priority should be:
dir_flag < comp_extention < no_comp_extention < comp_file_flag, no_comp_file_flag.
-----邮件原件-----
发件人: Jaegeuk Kim <jaegeuk@kernel.org>
发送时间: 2021年4月20日 0:23
收件人: Fengnan Chang <fengnanchang@gmail.com>
抄送: yuchao0@huawei.com; changfengnan@vivo.com;
linux-f2fs-devel@lists.sourceforge.net
主题: Re: [f2fs-dev] 答复: [RFC PATCH] f2fs: add no compress extensions
support
On 04/17, Fengnan Chang wrote:
> In this patch, we cannot handle files without extensions. At the moment
> there is just a rough idea,test a portion of the data to decide whether
> to compress it before performing a full compression. It may need more
> test. Any other suggestions?
>
> In my consider, the non-compress flag has a higher priority than the
> compressed flag.
> 1. the same extension name cannot not appear in both compress and
> non-compress extension at the same time, check this in mount process.
> 2. If the compress extension specifies all files, the types specified by
> the non-compress extension will be treated as special cases and will not
> be compressed.
> 3. If the non-compress extension specifies all files, should not specifies
> any compress extension, check in mount process too.
Do we need to support * for non-compress?
>
> Any other suggestions?
So, what could the priority for all the below combinations?
E.g., comp_extention, no_comp_extention, dir_flag, comp_file_flag,
no_comp_file_flag.
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-04-20 2:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 9:47 [f2fs-dev] [RFC PATCH] f2fs: add no compress extensions support Fengnan Chang
2021-04-15 1:31 ` Chao Yu
2021-04-15 1:56 ` [f2fs-dev] 答复: " changfengnan
2021-04-17 2:43 ` Chao Yu
2021-04-17 7:02 ` [f2fs-dev] =?y?q?Re=3A=20=5Bf2fs-dev=5D=20=E7=AD=94=E5=A4=8D=3A=20=20=5BRFC=20PATCH=5D=20f2fs=3A=20add=20no=20compress=20extensions=20support?= Fengnan Chang
2021-04-19 16:22 ` [f2fs-dev] 答复: [RFC PATCH] f2fs: add no compress extensions support Jaegeuk Kim
2021-04-20 2:08 ` changfengnan [this message]
2021-04-21 13:06 ` [f2fs-dev] 答复: " changfengnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003b01d73589$fd640060$f82c0120$@vivo.com' \
--to=changfengnan@vivo.com \
--cc=fengnanchang@gmail.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).