From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B571C7619A for ; Sun, 2 Apr 2023 03:17:35 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pioDn-0005fl-0U; Sun, 02 Apr 2023 03:17:34 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pioDl-0005fe-HV for linux-f2fs-devel@lists.sourceforge.net; Sun, 02 Apr 2023 03:17:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-ID:Date:Subject:In-Reply-To:References:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=o5rFwZN4arfT+quf2ScnUr6XHy1fT8u5eEhmQaaASlA=; b=mIrl3TN0s3+yjpngrpO8jNyGFQ FXZhrR2QKRYqPsH4y5ZSF4ImNXSq7yCkPhpHqL2A4852a3/b5CCB8/tBKJAa15Zmw7Y4d+pBb9eUr ztQ0+ergOFRsCqWESh7gGvVGfHvebn52heeQx8jcOb+ZwhRm++4LixvsDp0dRRpudGs0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date: Subject:In-Reply-To:References:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=o5rFwZN4arfT+quf2ScnUr6XHy1fT8u5eEhmQaaASlA=; b=KzXm73Mcq4Erg9RNykDz0FBUkY oe1GcDc5l5iRZoaRYE5nE8/5cWC1fZp++jhnYTVp08Haj5qMh01SumKXw+Yx8rnLgSJMr8zVaoQPR hIXfnS8bHBd0bhtZHTl8Q+aObemd1wez04pwIj8zmP+zDlz5LwuCcrX1Mu7ASOH5Hmc8=; Received: from mail-pl1-f177.google.com ([209.85.214.177]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1pioDj-00CRuc-Uj for linux-f2fs-devel@lists.sourceforge.net; Sun, 02 Apr 2023 03:17:32 +0000 Received: by mail-pl1-f177.google.com with SMTP id c18so25020147ple.11 for ; Sat, 01 Apr 2023 20:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680405446; h=thread-index:content-language:content-transfer-encoding :mime-version:message-id:date:subject:in-reply-to:references:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=o5rFwZN4arfT+quf2ScnUr6XHy1fT8u5eEhmQaaASlA=; b=UtJwdvLcUzjHvS4wnr5R9NIdmpRy6wBEEas5o3BT9o69hT5Vz08J0Zuf2ICuZD9XGG C5w0FvFlIKJYyQ1khXc2idyl4nDJpNL2DoxFyJH5saGIoyOr7OewMf1aCDzdN+iGeSx4 qSaeYfjFQFmhgzZOrdkQtbU4RK/VJxaiY9Ch3UYq1v74Fu+IbGNMMAjkuPlt0y6hZ9+b v51xxp/pM2HcA5x/PHaLiqd1ryKNaiiqWZ4VeAXrpMYYykaBQ0N4whK64E8bz7Ec0dmH wcwh+nUVWttKWk1D7R+85oxMlbrqFLqnpn0nLSvAw852EkPidEIcGETuo7uXBHFspkIr U57A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680405446; h=thread-index:content-language:content-transfer-encoding :mime-version:message-id:date:subject:in-reply-to:references:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o5rFwZN4arfT+quf2ScnUr6XHy1fT8u5eEhmQaaASlA=; b=iQAfjG4iFPi/bIXlRbdO6fZ9z1NGuhw72PIRatgRJsAUcKoaZ85mWMi0QBzZgge5aQ Yc/AXaIcfn0bv5K3P6uElO+pkVYlBlxWPsnUUIB2zTNsIgFwuiVCgB6BoXu9pP3TpCAl tUFLtMhiPt7CSxj+w3KnoIKb/nynAoRrUY4LiL34mwdUxx0zuIOgRTYHDa2I72emgqZH dCX57Wh2P62NCQHYzf1gizxHZTfCJzMayVPCJ1nTgsTBDM4oG4D9cRGNtdBxa2Z9YBYp giFLBQrKBBqYU3x1t5pwykTpzt7Hj7fXMO+n2BuetUtASb0QUCpLmU0uKbm1om79YLMA x4LA== X-Gm-Message-State: AAQBX9dfRR8csDHX+fqIrd8dAwTuIiDXoU4ZBKvGJxg1lMUfDyMisvFp KYxwcQVRhmN3Z9GdUEAmLvo= X-Google-Smtp-Source: AKy350YYP/el4R+46FhTkfdbpKa6uJ7uWQynmnEpS0NPC1S2v7kjvu2+wGLivgc7UCCGp6co5tmkaQ== X-Received: by 2002:a17:903:1250:b0:1a2:55ca:6669 with SMTP id u16-20020a170903125000b001a255ca6669mr28198412plh.33.1680405446264; Sat, 01 Apr 2023 20:17:26 -0700 (PDT) Received: from DESKTOPB5TBVBT ([175.117.51.71]) by smtp.gmail.com with ESMTPSA id bd10-20020a170902830a00b001991f3d85acsm3989098plb.299.2023.04.01.20.17.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Apr 2023 20:17:25 -0700 (PDT) From: "Yohan Joung" To: "'Chao Yu'" , References: <20230324130747.523-1-jyh429@gmail.com> <6db7be47-9455-c466-f99a-497f8fe8930a@kernel.org> In-Reply-To: <6db7be47-9455-c466-f99a-497f8fe8930a@kernel.org> Date: Sun, 2 Apr 2023 12:17:23 +0900 Message-ID: <004e01d96511$a65359b0$f2fa0d10$@gmail.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 15.0 Content-Language: ko Thread-Index: AQF6XO6yHRdACLHpz3GwDztUEe2YOQJb5qXHAomEG4Svrj19UA== X-Headers-End: 1pioDj-00CRuc-Uj Subject: Re: [f2fs-dev] [PATCH] f2fs: fix align check for npo2 X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: oe-kbuild-all@lists.linux.dev, linux-f2fs-devel@lists.sourceforge.net, lkp@intel.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net > -----Original Message----- > From: Chao Yu [mailto:chao@kernel.org] > Sent: Saturday, April 1, 2023 10:49 AM > To: Yohan Joung; jaegeuk@kernel.org > Cc: lkp@intel.com; linux-kernel@vger.kernel.org; linux-f2fs- > devel@lists.sourceforge.net; oe-kbuild-all@lists.linux.dev > Subject: Re: [f2fs-dev] [PATCH] f2fs: fix align check for npo2 > > On 2023/3/24 21:07, Yohan Joung wrote: > > Fix alignment check to be correct in npo2 as well > > > > Signed-off-by: Yohan Joung > > --- > > fs/f2fs/segment.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index > > 055e70e77aa2..f4a22a065277 100644 > > --- a/fs/f2fs/segment.c > > +++ b/fs/f2fs/segment.c > > @@ -1842,6 +1842,7 @@ static int __f2fs_issue_discard_zone(struct > f2fs_sb_info *sbi, > > sector_t sector, nr_sects; > > block_t lblkstart = blkstart; > > int devi = 0; > > + u32 remainder = 0; > > > > if (f2fs_is_multi_device(sbi)) { > > devi = f2fs_target_device_index(sbi, blkstart); @@ -1857,9 > +1858,9 > > @@ static int __f2fs_issue_discard_zone(struct f2fs_sb_info *sbi, > > if (f2fs_blkz_is_seq(sbi, devi, blkstart)) { > > sector = SECTOR_FROM_BLOCK(blkstart); > > nr_sects = SECTOR_FROM_BLOCK(blklen); > > + div_u64_rem(sector, bdev_zone_sectors(bdev), &remainder); > > Should use div64_u64_rem()? As both sector and return value of > bdev_zone_sectors() are u64. > > Thanks, Upload based on your comments. Thanks > > > > > - if (sector & (bdev_zone_sectors(bdev) - 1) || > > - nr_sects != bdev_zone_sectors(bdev)) { > > + if (remainder || nr_sects != bdev_zone_sectors(bdev)) { > > f2fs_err(sbi, "(%d) %s: Unaligned zone reset attempted > (block %x + %x)", > > devi, sbi->s_ndevs ? FDEV(devi).path : "", > > blkstart, blklen); _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel