Re: [PATCH 1/2] mkfs.f2fs: support large sector size

[Chao Yu <chao2.yu@samsung.com>]

Hi Kinglong,

> -----Original Message-----
> From: Kinglong Mee [mailto:kinglongmee@gmail.com]
> Sent: Wednesday, February 04, 2015 9:43 PM
> To: Chao Yu
> Cc: Jaegeuk Kim; Changman Lee; linux-kernel@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net
> Subject: Re: [f2fs-dev] [PATCH 1/2] mkfs.f2fs: support large sector size
> 
> Hi Chao,
> 
> On Wed, Feb 4, 2015 at 11:30 AM, Chao Yu <chao2.yu@samsung.com> wrote:
> > Since f2fs support large sector size in commit 55cf9cb63f0e "f2fs: support large
> > sector size", block device with sector size of 512/1024/2048/4096 bytes can be
> > supported.
> >
> > But mkfs.f2fs still use default sector size: 512 bytes as sector size, let's fix
> > this issue in this patch.
> >
> > v2:
> >  o remove unneeded printed message when sector size is large than 512 bytes
> >    suggested by Kinglong.
> >  o show correct sector size in printed message.
> >  o use config.sectors_per_blk instead of DEFAULT_SECTORS_PER_BLOCK suggested by
> >    Kinglong.
> >
> > Signed-off-by: Chao Yu <chao2.yu@samsung.com>
> > ---
> >  lib/libf2fs.c            | 10 +++-------
> >  mkfs/f2fs_format.c       | 12 ++++++------
> >  mkfs/f2fs_format_utils.c |  2 +-
> >  3 files changed, 10 insertions(+), 14 deletions(-)
> >
> > diff --git a/lib/libf2fs.c b/lib/libf2fs.c
> > index 8123528..d2942f0 100644
> > --- a/lib/libf2fs.c
> > +++ b/lib/libf2fs.c
> > @@ -463,10 +463,6 @@ int f2fs_get_device_info(struct f2fs_configuration *c)
> >                         MSG(0, "\tError: Using the default sector size\n");
> >                 } else {
> >                         if (c->sector_size < sector_size) {
> > -                               MSG(0, "\tError: Cannot set the sector size to:"
> > -                                       " %d as the device does not support"
> > -                                       "\nSetting the sector size to : %d\n",
> > -                                       c->sector_size, sector_size);
> >                                 c->sector_size = sector_size;
> >                                 c->sectors_per_blk = PAGE_SIZE / sector_size;
> >                         }
> > @@ -495,8 +491,8 @@ int f2fs_get_device_info(struct f2fs_configuration *c)
> >                 return -1;
> >         }
> >         if (wanted_total_sectors && wanted_total_sectors < c->total_sectors) {
> > -               MSG(0, "Info: total device sectors = %"PRIu64" (in 512bytes)\n",
> > -                                       c->total_sectors);
> > +               MSG(0, "Info: total device sectors = %"PRIu64" (in %u bytes)\n",
> > +                                       c->total_sectors, c->sector_size);
> >                 c->total_sectors = wanted_total_sectors;
> >
> >         }
> > @@ -504,7 +500,7 @@ int f2fs_get_device_info(struct f2fs_configuration *c)
> >         MSG(0, "Info: total sectors = %"PRIu64" (in 512bytes)\n",
> 
> This "512bytes" should be modified as above too.

Oh my miss, sorry about this. I will resend the patch.

thanks,
Yu
> 
> thanks,
> Kinglong Mee


------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/