From: Chao Yu <chao2.yu@samsung.com>
To: 'hujianyang' <hujianyang@huawei.com>, 'Jaegeuk Kim' <jaegeuk@kernel.org>
Cc: namjae.jeon@samsung.com, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] f2fs: add compat_ioctl to f2fs_dir_operations
Date: Tue, 12 May 2015 17:54:53 +0800 [thread overview]
Message-ID: <009b01d08c99$cc49fbf0$64ddf3d0$@samsung.com> (raw)
In-Reply-To: <5551B465.8000804@huawei.com>
Hi Jianyang,
> -----Original Message-----
> From: hujianyang [mailto:hujianyang@huawei.com]
> Sent: Tuesday, May 12, 2015 4:06 PM
> To: Jaegeuk Kim
> Cc: Chao Yu; namjae.jeon@samsung.com; linux-f2fs-devel@lists.sourceforge.net
> Subject: [f2fs-dev][PATCH] f2fs: add compat_ioctl to f2fs_dir_operations
>
> commit e9750824114ff939d9da299e73651add6aa65456
>
> f2fs: add compat_ioctl to provide backward compatability
>
> introduce compat_ioctl to regular files, but doesn't add this
> functionality to f2fs_dir_operations.
>
> While running a 32-bit busybox, I met an error like this:
> (A is a directory)
>
> # busybox chattr +i A
> chattr: reading flags on A: Inappropriate ioctl for device
>
> This patch copies compat_ioctl from f2fs_file_operations and
> fix this problem.
Looks good to me.
>
> Signed-off-by: hujianyang <hujianyang@huawei.com>
Reviewed-by: Chao Yu <chao2.yu@samsung.com>
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
prev parent reply other threads:[~2015-05-12 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 8:05 [PATCH] f2fs: add compat_ioctl to f2fs_dir_operations hujianyang
2015-05-12 9:54 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009b01d08c99$cc49fbf0$64ddf3d0$@samsung.com' \
--to=chao2.yu@samsung.com \
--cc=hujianyang@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).