From: Jeff Layton <jlayton@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Latchesar Ionkov" <lucho@ionkov.net>,
"Konstantin Komarov" <almaz.alexandrovich@paragon-software.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
"Anders Larsen" <al@alarsen.net>,
"Carlos Llamas" <cmllamas@google.com>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Mattia Dongili" <malattia@linux.it>,
"Hugh Dickins" <hughd@google.com>,
"John Johansen" <john.johansen@canonical.com>,
"Yonghong Song" <yonghong.song@linux.dev>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christoph Hellwig" <hch@lst.de>,
"Mike Marshall" <hubcap@omnibond.com>,
"Paulo Alcantara" <pc@manguebit.com>,
linux-xfs@vger.kernel.org,
"Michael Ellerman" <mpe@ellerman.id.au>,
"James Morris" <jmorris@namei.org>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Christoph Hellwig" <hch@infradead.org>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
devel@lists.orangefs.org,
"Shyam Prasad N" <sprasad@microsoft.com>,
linux-um@lists.infradead.org,
"Nicholas Piggin" <npiggin@gmail.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Eric Van Hensbergen" <ericvh@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Trond Myklebust" <trond.myklebust@hammerspace.com>,
"Anton Altaparmakov" <anton@tuxera.com>,
"Christian Brauner" <brauner@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Stephen Smalley" <stephen.smalley.work@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Ronnie Sahlberg" <lsahlber@redhat.com>,
"Sergey Senozhatsky" <senozhatsky@chromium.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Chuck Lever" <chuck.lever@oracle.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"Jiri Olsa" <jolsa@kernel.org>, "Jan Kara" <jack@suse.com>,
"Tejun Heo" <tj@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-trace-kernel@vger.kernel.org,
"Dave Kleikamp" <shaggy@kernel.org>,
linux-mm@kvack.org, "Joel Fernandes" <joel@joelfernandes.org>,
"Eric Dumazet" <edumazet@google.com>,
"Stanislav Fomichev" <sdf@google.com>,
linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
"Paul Moore" <paul@paul-moore.com>,
"Leon Romanovsky" <leon@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
"Luis Chamberlain" <mcgrof@kernel.org>,
codalist@coda.cs.cmu.edu, "Iurii Zaikin" <yzaikin@google.com>,
"Namjae Jeon" <linkinjeon@kernel.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Todd Kjos" <tkjos@android.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
selinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
reiserfs-devel@vger.kernel.org,
"Miklos Szeredi" <miklos@szeredi.hu>,
"Yue Hu" <huyue2@coolpad.com>, "Jaegeuk Kim" <jaegeuk@kernel.org>,
"Martijn Coenen" <maco@android.com>,
"OGAWA Hirofumi" <hirofumi@mail.parknet.co.jp>,
"Hao Luo" <haoluo@google.com>, "Tony Luck" <tony.luck@intel.com>,
"Theodore Ts'o" <tytso@mit.edu>,
"Nicolas Pitre" <nico@fluxnic.net>,
linux-ntfs-dev@lists.sourceforge.net,
"Muchun Song" <muchun.song@linux.dev>,
linux-f2fs-devel@lists.sourceforge.net,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
gfs2@lists.linux.dev, "Eric Biederman" <ebiederm@xmission.com>,
"Anna Schumaker" <anna@kernel.org>,
"Brad Warrum" <bwarrum@linux.ibm.com>,
"Mike Kravetz" <mike.kravetz@oracle.com>,
linux-efi@vger.kernel.org,
"Martin Brandenburg" <martin@omnibond.com>,
ocfs2-devel@lists.linux.dev,
"Alexei Starovoitov" <ast@kernel.org>,
platform-driver-x86@vger.kernel.org, "Chris Mason" <clm@fb.com>,
linux-mtd@lists.infradead.org, linux-hardening@vger.kernel.org,
"Marc Dionne" <marc.dionne@auristor.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
linux-afs@lists.infradead.org, "Ian Kent" <raven@themaw.net>,
"Naohiro Aota" <naohiro.aota@wdc.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Dennis Dalessandro" <dennis.dalessandro@cornelisnetworks.com>,
linux-rdma@vger.kernel.org, coda@cs.cmu.edu,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Ilya Dryomov" <idryomov@gmail.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
"Christian Schoenebeck" <linux_oss@crudebyte.com>,
"Kees Cook" <keescook@chromium.org>,
"Arnd Bergmann" <arnd@arndb.de>,
autofs@vger.kernel.org, "Steven Rostedt" <rostedt@goodmis.org>,
"Mark Gross" <markgross@kernel.org>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Eric Paris" <eparis@parisplace.org>,
ceph-devel@vger.kernel.org, "Gao Xiang" <xiang@kernel.org>,
"Jan Harkes" <jaharkes@cs.cmu.edu>,
linux-nfs@vger.kernel.org, linux-ext4@vger.kernel.org,
"Olga Kornievskaia" <kolga@netapp.com>,
"Song Liu" <song@kernel.org>,
samba-technical@lists.samba.org,
"Steve French" <sfrench@samba.org>, "Jeremy Kerr" <jk@ozlabs.org>,
netdev@vger.kernel.org, "Bob Peterson" <rpeterso@redhat.com>,
linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org,
ntfs3@lists.linux.dev, linux-erofs@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
"Chandan Babu R" <chandan.babu@oracle.com>,
jfs-discussion@lists.sourceforge.net, "Jan Kara" <jack@suse.cz>,
"Neil Brown" <neilb@suse.de>,
"Dominique Martinet" <asmadeus@codewreck.org>,
"Amir Goldstein" <amir73il@gmail.com>,
"Bob Copeland" <me@bobcopeland.com>,
"KP Singh" <kpsingh@kernel.org>,
linux-unionfs@vger.kernel.org,
"David Howells" <dhowells@redhat.com>,
"Joseph Qi" <joseph.qi@linux.alibaba.com>,
"Andreas Dilger" <adilger.kernel@dilger.ca>,
"Mikulas Patocka" <mikulas@artax.karlin.mff.cuni.cz>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Anton Ivanov" <anton.ivanov@cambridgegreys.com>,
"Andreas Gruenbacher" <agruenba@redhat.com>,
"Richard Weinberger" <richard@nod.at>,
"Mark Fasheh" <mark@fasheh.com>, "Dai Ngo" <Dai.Ngo@oracle.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
linux-serial@vger.kernel.org, "Jakub Kicinski" <kuba@kernel.org>,
"Salah Triki" <salah.triki@gmail.com>,
"Evgeniy Dushistov" <dushistov@mail.ru>,
linux-cifs@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>,
apparmor@lists.ubuntu.com, "Josef Bacik" <josef@toxicpanda.com>,
"Tom Talpey" <tom@talpey.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Tigran A. Aivazian" <aivazian.tigran@gmail.com>,
"David Sterba" <dsterba@suse.com>, "Xiubo Li" <xiubli@redhat.com>,
"Ryusuke Konishi" <konishi.ryusuke@gmail.com>,
"Johannes Thumshirn" <jth@kernel.org>,
"Ritu Agarwal" <rituagar@linux.ibm.com>,
"Luis de Bethencourt" <luisbg@kernel.org>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
v9fs@lists.linux.dev, "David Sterba" <dsterba@suse.cz>,
linux-security-module@vger.kernel.org,
"Jeffle Xu" <jefflexu@linux.alibaba.com>,
"Phillip Lougher" <phillip@squashfs.org.uk>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Sungjong Seo" <sj1557.seo@samsung.com>,
"David Woodhouse" <dwmw2@infradead.org>,
linux-karma-devel@lists.sourceforge.net,
linux-btrfs@vger.kernel.org, "Joel Becker" <jlbec@evilplan.org>
Subject: Re: [f2fs-dev] [PATCH 87/87] fs: move i_blocks up a few places in struct inode
Date: Thu, 28 Sep 2023 14:01:33 -0400 [thread overview]
Message-ID: <00ca2e3997cc86401f7fb65d936fe5403abd5627.camel@kernel.org> (raw)
In-Reply-To: <CAHk-=wij_42Q9WHY898r-gugmT5c-1JJKRh3C+nTUd1hc1aeqQ@mail.gmail.com>
On Thu, 2023-09-28 at 10:41 -0700, Linus Torvalds wrote:
> On Thu, 28 Sept 2023 at 04:06, Jeff Layton <jlayton@kernel.org> wrote:
> >
> > Move i_blocks up above the i_lock, which moves the new 4 byte hole to
> > just after the timestamps, without changing the size of the structure.
>
> I'm sure others have mentioned this, but 'struct inode' is marked with
> __randomize_layout, so the actual layout may end up being very
> different.
>
> I'm personally not convinced the whole structure randomization is
> worth it - it's easy enough to figure out for any distro kernel since
> the seed has to be the same across machines for modules to work, so
> even if the seed isn't "public", any layout is bound to be fairly
> easily discoverable.
>
> So the whole randomization only really works for private kernel
> builds, and it adds this kind of pain where "optimizing" the structure
> layout is kind of pointless depending on various options.
>
> I certainly *hope* no distro enables that pointless thing, but it's a worry.
>
I've never enabled struct randomization and don't know anyone who does.
I figure if you turn that on, you get to keep all of the pieces when you
start seeing weird performance problems.
I think that we have to optimize for that being disabled. Even without
that though, turning on and off options can change the layout...and then
there are different arches, etc.
I'm using a config derived from the Fedora x86_64 kernel images and hope
that represents a reasonably common configuration. The only conditional
members before the timestamps are based on CONFIG_FS_POSIX_ACL and
CONFIG_SECURITY, which are almost always turned on with most distros.
--
Jeff Layton <jlayton@kernel.org>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-09-28 18:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 11:05 [f2fs-dev] [PATCH 85/87] fs: rename i_atime and i_mtime fields to __i_atime and __i_mtime Jeff Layton
2023-09-28 11:05 ` [f2fs-dev] [PATCH 86/87] fs: switch timespec64 fields in inode to discrete integers Jeff Layton
2023-09-28 15:48 ` Arnd Bergmann
2023-09-28 17:06 ` Jeff Layton
2023-09-28 17:19 ` Darrick J. Wong
2023-09-28 17:40 ` Jeff Layton
2023-09-28 20:21 ` Arnd Bergmann
2023-09-28 21:26 ` Theodore Ts'o
2023-09-29 0:18 ` Linus Torvalds
2023-09-29 3:50 ` Amir Goldstein
2023-09-29 16:22 ` Linus Torvalds
2023-09-29 3:27 ` Amir Goldstein
2023-09-29 6:32 ` David Howells
2023-09-30 14:50 ` Steve French
2023-10-01 5:01 ` [f2fs-dev] [OT] " Gabriel Paubert
2023-09-29 9:44 ` [f2fs-dev] " Christian Brauner
2023-09-29 10:16 ` Jeff Layton
2023-09-28 17:09 ` Jeff Layton
2023-09-28 11:05 ` [f2fs-dev] [PATCH 87/87] fs: move i_blocks up a few places in struct inode Jeff Layton
2023-09-28 11:35 ` Amir Goldstein
2023-09-28 12:01 ` Jeff Layton
2023-09-28 17:41 ` Linus Torvalds
2023-09-28 18:01 ` Jeff Layton [this message]
2023-09-29 9:32 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00ca2e3997cc86401f7fb65d936fe5403abd5627.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=agordeev@linux.ibm.com \
--cc=agruenba@redhat.com \
--cc=aivazian.tigran@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=al@alarsen.net \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=amir73il@gmail.com \
--cc=andrii@kernel.org \
--cc=anna@kernel.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=anton@tuxera.com \
--cc=apparmor@lists.ubuntu.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=asmadeus@codewreck.org \
--cc=ast@kernel.org \
--cc=autofs@vger.kernel.org \
--cc=borntraeger@linux.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=bwarrum@linux.ibm.com \
--cc=ceph-devel@vger.kernel.org \
--cc=chandan.babu@oracle.com \
--cc=christophe.leroy@csgroup.eu \
--cc=chuck.lever@oracle.com \
--cc=clm@fb.com \
--cc=cmllamas@google.com \
--cc=coda@cs.cmu.edu \
--cc=codalist@coda.cs.cmu.edu \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=devel@lists.orangefs.org \
--cc=dhowells@redhat.com \
--cc=djwong@kernel.org \
--cc=dlemoal@kernel.org \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=dushistov@mail.ru \
--cc=dwmw2@infradead.org \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=eparis@parisplace.org \
--cc=ericvh@kernel.org \
--cc=gfs2@lists.linux.dev \
--cc=gor@linux.ibm.com \
--cc=gpiccoli@igalia.com \
--cc=gregkh@linuxfoundation.org \
--cc=haoluo@google.com \
--cc=hca@linux.ibm.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=hdegoede@redhat.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=hubcap@omnibond.com \
--cc=hughd@google.com \
--cc=huyue2@coolpad.com \
--cc=idryomov@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=jaharkes@cs.cmu.edu \
--cc=jefflexu@linux.alibaba.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jgg@ziepe.ca \
--cc=jirislaby@kernel.org \
--cc=jk@ozlabs.org \
--cc=jlbec@evilplan.org \
--cc=jmorris@namei.org \
--cc=joel@joelfernandes.org \
--cc=johannes@sipsolutions.net \
--cc=john.fastabend@gmail.com \
--cc=john.johansen@canonical.com \
--cc=jolsa@kernel.org \
--cc=josef@toxicpanda.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=jth@kernel.org \
--cc=keescook@chromium.org \
--cc=kolga@netapp.com \
--cc=konishi.ryusuke@gmail.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linkinjeon@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-karma-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lsahlber@redhat.com \
--cc=lucho@ionkov.net \
--cc=luisbg@kernel.org \
--cc=maco@android.com \
--cc=malattia@linux.it \
--cc=marc.dionne@auristor.com \
--cc=mark@fasheh.com \
--cc=markgross@kernel.org \
--cc=martin.lau@linux.dev \
--cc=martin@omnibond.com \
--cc=mcgrof@kernel.org \
--cc=me@bobcopeland.com \
--cc=mhiramat@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=miklos@szeredi.hu \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=mpe@ellerman.id.au \
--cc=muchun.song@linux.dev \
--cc=naohiro.aota@wdc.com \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=npiggin@gmail.com \
--cc=ntfs3@lists.linux.dev \
--cc=ocfs2-devel@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=paul@paul-moore.com \
--cc=pc@manguebit.com \
--cc=phillip@squashfs.org.uk \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=raven@themaw.net \
--cc=reiserfs-devel@vger.kernel.org \
--cc=richard@nod.at \
--cc=rituagar@linux.ibm.com \
--cc=rostedt@goodmis.org \
--cc=rpeterso@redhat.com \
--cc=salah.triki@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sdf@google.com \
--cc=selinux@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=serge@hallyn.com \
--cc=sfrench@samba.org \
--cc=shaggy@kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=song@kernel.org \
--cc=sprasad@microsoft.com \
--cc=stephen.smalley.work@gmail.com \
--cc=surenb@google.com \
--cc=svens@linux.ibm.com \
--cc=tj@kernel.org \
--cc=tkjos@android.com \
--cc=tom@talpey.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=trond.myklebust@hammerspace.com \
--cc=tytso@mit.edu \
--cc=v9fs@lists.linux.dev \
--cc=viro@zeniv.linux.org.uk \
--cc=xiang@kernel.org \
--cc=xiubli@redhat.com \
--cc=yonghong.song@linux.dev \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).