From: Chao Yu <chao2.yu@samsung.com>
To: 'Dan Carpenter' <dan.carpenter@oracle.com>
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: f2fs: reorganize f2fs_map_blocks
Date: Tue, 22 Sep 2015 21:21:01 +0800 [thread overview]
Message-ID: <00d701d0f539$9eadb6b0$dc092410$@samsung.com> (raw)
In-Reply-To: <20150921162508.GD5648@mwanda>
Hi Dan,
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Tuesday, September 22, 2015 12:25 AM
> To: chao2.yu@samsung.com
> Cc: linux-f2fs-devel@lists.sourceforge.net
> Subject: re: f2fs: reorganize f2fs_map_blocks
>
> Hello Chao Yu,
>
> The patch bce86a6c64a7: "f2fs: reorganize f2fs_map_blocks" from Sep
> 11, 2015, leads to the following static checker warning:
>
> fs/f2fs/data.c:653 f2fs_map_blocks()
> warn: was || intended here instead of &&?
>
> fs/f2fs/data.c
> 650 if (maxblocks > map->m_len) {
> 651 block_t blkaddr = datablock_addr(dn.node_page, dn.ofs_in_node);
> 652
> 653 if (blkaddr == NEW_ADDR && blkaddr == NULL_ADDR) {
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Impossible condition.
Thanks for pointing it out. :)
My v2 patch sent several days ago has fixed that issue.
Thanks,
------------------------------------------------------------------------------
prev parent reply other threads:[~2015-09-22 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 16:25 f2fs: reorganize f2fs_map_blocks Dan Carpenter
2015-09-21 18:43 ` Jaegeuk Kim
2015-09-22 13:21 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00d701d0f539$9eadb6b0$dc092410$@samsung.com' \
--to=chao2.yu@samsung.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).