From: Chao Yu <chao2.yu@samsung.com>
To: 'Marc Lehmann' <schmorp@schmorp.de>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: have ioctls changed?
Date: Tue, 17 Nov 2015 10:34:15 +0800 [thread overview]
Message-ID: <00e801d120e0$8bff42e0$a3fdc8a0$@samsung.com> (raw)
In-Reply-To: <20151117013634.GA4104@schmorp.de>
Hi,
> -----Original Message-----
> From: Marc Lehmann [mailto:schmorp@schmorp.de]
> Sent: Tuesday, November 17, 2015 9:37 AM
> To: linux-f2fs-devel@lists.sourceforge.net
> Subject: [f2fs-dev] have ioctls changed?
>
> Hi!
>
> While trying the new f2fs snapshot (3.18 branch from yesterday), I found that
> my GC script does no longer work:
>
> ioctl(0, 0xf506, 0x1741810) = -1 ENOTTY (Inappropriate ioctl for device)
>
> fd#0 is from open ("/mountpoint",...). I didn't upgrade kernels or
> anything else - the script works with the module I previously used.
We didn't change the main interface (0xf506) of ioctl for GC, but did change
the usage of parameter passed of it.
So, firstly, could you please check whether below commits exist in your
branch:
- c1c1b58359d4 ("f2fs: add new ioctl F2FS_IOC_GARBAGE_COLLECT")
- d530d4d8e237 ("f2fs: support synchronous gc in ioctl")
Then, if it exists, I think it's better to check the real file opened which
fd#0 points to since I'm not sure this file is belong to f2fs.
Thanks,
>
> So, have the ioctls changed recently, or some detail about them?
>
> --
> The choice of a Deliantra, the free code+content MORPG
> -----==- _GNU_ http://www.deliantra.net
> ----==-- _ generation
> ---==---(_)__ __ ____ __ Marc Lehmann
> --==---/ / _ \/ // /\ \/ / schmorp@schmorp.de
> -=====/_/_//_/\_,_/ /_/\_\
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
------------------------------------------------------------------------------
next prev parent reply other threads:[~2015-11-17 2:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 1:36 have ioctls changed? Marc Lehmann
2015-11-17 2:34 ` Chao Yu [this message]
2015-11-17 3:45 ` Marc Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00e801d120e0$8bff42e0$a3fdc8a0$@samsung.com' \
--to=chao2.yu@samsung.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=schmorp@schmorp.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).