From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Subject: Re: f2fs bug: Unable to mount big volumes in kernel 4.5 Date: Tue, 22 Mar 2016 11:37:53 +0800 Message-ID: <013e01d183ec$5142ae20$f3c80a60$@samsung.com> References: <56EEC766.2030503@davizone.at> <20160320224654.GB4752@jaegeuk.hsd1.ca.comcast.net> <00d401d18320$75f94e80$61ebeb80$@samsung.com> <20160321103032.GA2739@schmorp.de> <20160321160359.GB6196@jaegeuk.gateway> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1aiD9e-0000hH-Qp for linux-f2fs-devel@lists.sourceforge.net; Tue, 22 Mar 2016 03:38:50 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:AES128-SHA:128) (Exim 4.76) id 1aiD9c-0001cN-PP for linux-f2fs-devel@lists.sourceforge.net; Tue, 22 Mar 2016 03:38:50 +0000 Received: from epcpsbgm2new.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O4F0015E8SHCL50@mailout2.samsung.com> for linux-f2fs-devel@lists.sourceforge.net; Tue, 22 Mar 2016 12:38:41 +0900 (KST) In-reply-to: <20160321160359.GB6196@jaegeuk.gateway> Content-language: zh-cn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: 'Jaegeuk Kim' , 'Marc Lehmann' Cc: linux-f2fs-devel@lists.sourceforge.net Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Tuesday, March 22, 2016 12:04 AM > To: Marc Lehmann > Cc: Chao Yu; linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] f2fs bug: Unable to mount big volumes in kernel 4.5 > > On Mon, Mar 21, 2016 at 11:30:38AM +0100, Marc Lehmann wrote: > > On Mon, Mar 21, 2016 at 11:18:35AM +0800, Chao Yu wrote: > > > > As you pointed out, it seems there is a bug in sanity check routine, which > > > > doesn't cover the large section case. > > > > > > Actually, there is a bug in f2fs-tools 1.6.0, it will trigger sanity check failure > > > in f2fs kernel module since in mkfs.f2fs we will align segment_count and > > > segment_count_main with different size if parameter -s or -z is configured larger > > > than 1. > > > > > > Following commit in dev branch of f2fs-tools has fixed this issue, could you test this > > > patch firstly? > > > ("mkfs.f2fs: set segment_count in super block correctly") > > > > Stupid question from my side, does that mean we have to reformat existing > > volumes? Because mkfs clearly won't fix existing volumes, so fixing mkfs > > will not fix the issue. > > Exactly. > The f2fs patch should be merged to take into account such the backward > compatibility. Agreed. > And, I don't think wrong segment_count hurts the f2fs behavior. Now, we use segment_count to check our last blkaddr, if we ignore correctness of segment_count, our boundary checked should be wrong. So how about enabling fsck.f2fs ability of repairing incorrect value of segment_count, and for f2fs module, warn our user to run fsck if we detect such error? Thanks, > > Thanks, > > > > > A fix in the f2fs or fsck.f2fs would be needed for existing volumes. > > > > -- > > The choice of a Deliantra, the free code+content MORPG > > -----==- _GNU_ http://www.deliantra.net > > ----==-- _ generation > > ---==---(_)__ __ ____ __ Marc Lehmann > > --==---/ / _ \/ // /\ \/ / schmorp@schmorp.de > > -=====/_/_//_/\_,_/ /_/\_\ ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140