* [PATCH] f2fs: remove unnecessary initialization
@ 2016-08-23 12:10 Sheng Yong
2016-08-25 14:10 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Sheng Yong @ 2016-08-23 12:10 UTC (permalink / raw)
To: jaegeuk, chao; +Cc: linux-f2fs-devel
`flags' is used to save value from userspace, there is no need to
initialize it, and FS_FL_USER_VISIBLE is the mask for getflags.
Signed-off-by: Sheng Yong <shengyong1@huawei.com>
---
fs/f2fs/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 47abb96..7c6ee7e 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1454,7 +1454,7 @@ static int f2fs_ioc_setflags(struct file *filp, unsigned long arg)
{
struct inode *inode = file_inode(filp);
struct f2fs_inode_info *fi = F2FS_I(inode);
- unsigned int flags = fi->i_flags & FS_FL_USER_VISIBLE;
+ unsigned int flags;
unsigned int oldflags;
int ret;
--
2.9.2
------------------------------------------------------------------------------
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] f2fs: remove unnecessary initialization
2016-08-23 12:10 [PATCH] f2fs: remove unnecessary initialization Sheng Yong
@ 2016-08-25 14:10 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2016-08-25 14:10 UTC (permalink / raw)
To: Sheng Yong, jaegeuk; +Cc: linux-f2fs-devel
On 2016/8/23 20:10, Sheng Yong wrote:
> `flags' is used to save value from userspace, there is no need to
> initialize it, and FS_FL_USER_VISIBLE is the mask for getflags.
>
> Signed-off-by: Sheng Yong <shengyong1@huawei.com>
Acked-by: Chao Yu <yuchao0@huawei.com>
------------------------------------------------------------------------------
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-25 14:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-23 12:10 [PATCH] f2fs: remove unnecessary initialization Sheng Yong
2016-08-25 14:10 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).