From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1C10C433B4 for ; Tue, 20 Apr 2021 01:53:16 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B13C06113C for ; Tue, 20 Apr 2021 01:53:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B13C06113C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1lYfZi-0000Tm-Np; Tue, 20 Apr 2021 01:53:14 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1lYfZh-0000Ta-3U for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Apr 2021 01:53:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=G9KuMT/EmgzVxuxVeZ+kzqUmsWTov+sdO2J/W/Ujme4=; b=KV6D+OQKFBeBbpZiqvIRywtwJI ffkTX1vCMDeyrpbQx06VArO7idy4RlUG6aOGs4jbsn77BkMT4gI9F4l/IOcWsf5i1pjThHjmfCSUU 0VyVM71p+gNJxs6eYEmb4VW9p0yAao0mMYHpWPoCImogHXtZxjISSG4K6dWgZ6B7v8MA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=G9KuMT/EmgzVxuxVeZ+kzqUmsWTov+sdO2J/W/Ujme4=; b=WY3CnNo7h/JeXTBd9CalwFZTKO wYuupHvaMt8amhBwyPs9nd/wk5pEx+Dy0dZN0fGGxk+0kkEBpQEGdQp3wJyXh6oAFKEQz8MR0orSd qEp42mEtlV1ToEBAmgg3ycnwvB5AgxDJ4BLSKG9puT61bvlprMkz0RzIv4DdTQZ9ZdyU=; Received: from szxga04-in.huawei.com ([45.249.212.190]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1lYfZV-00066R-M2 for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Apr 2021 01:53:13 +0000 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FPRSy1sJnzmdWg; Tue, 20 Apr 2021 09:49:54 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by smtp.huawei.com (10.3.19.201) with Microsoft SMTP Server (TLS) id 14.3.498.0; Tue, 20 Apr 2021 09:52:48 +0800 To: Jaegeuk Kim References: <20210414012134.128066-1-yuchao0@huawei.com> From: Chao Yu Message-ID: <03dc1c69-9215-1b5f-b1cc-c38454f3b90a@huawei.com> Date: Tue, 20 Apr 2021 09:52:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.136.110.154] X-CFilter-Loop: Reflected X-Headers-End: 1lYfZV-00066R-M2 Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to cover allocate_segment() with lock X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/4/20 0:57, Jaegeuk Kim wrote: > On 04/14, Chao Yu wrote: >> As we did for other cases, in fix_curseg_write_pointer(), let's >> change as below: >> - use callback function s_ops->allocate_segment() instead of >> raw function allocate_segment_by_default(); >> - cover allocate_segment() with curseg_lock and sentry_lock. >> >> Signed-off-by: Chao Yu >> --- >> fs/f2fs/segment.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c >> index b2ee6b7791b0..daf9531ec58f 100644 >> --- a/fs/f2fs/segment.c >> +++ b/fs/f2fs/segment.c >> @@ -4848,7 +4848,12 @@ static int fix_curseg_write_pointer(struct f2fs_sb_info *sbi, int type) >> >> f2fs_notice(sbi, "Assign new section to curseg[%d]: " >> "curseg[0x%x,0x%x]", type, cs->segno, cs->next_blkoff); >> - allocate_segment_by_default(sbi, type, true); >> + >> + down_read(&SM_I(sbi)->curseg_lock); >> + down_write(&SIT_I(sbi)->sentry_lock); >> + SIT_I(sbi)->s_ops->allocate_segment(sbi, type, true); >> + up_write(&SIT_I(sbi)->sentry_lock); >> + up_read(&SM_I(sbi)->curseg_lock); > > Seems f2fs_allocate_new_section()? f2fs_allocate_new_section() will allocate new section only when current section has been initialized and has valid block/ckpt_block. It looks fix_curseg_write_pointer() wants to force migrating current segment to new section whenever write pointer and curseg->next_blkoff is inconsistent. So how about adding a parameter to force f2fs_allocate_new_section() to allocate new section? Thanks, > >> >> /* check consistency of the zone curseg pointed to */ >> if (check_zone_write_pointer(sbi, zbd, &zone)) >> -- >> 2.29.2 > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel