From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4276C76186 for ; Thu, 25 Jul 2019 03:15:21 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7177E21855; Thu, 25 Jul 2019 03:15:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="FqhL9G8N"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="IB2CmuMN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7177E21855 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1hqUDx-0002Vz-1w; Thu, 25 Jul 2019 03:15:21 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hqUDt-0002Vp-AS for linux-f2fs-devel@lists.sourceforge.net; Thu, 25 Jul 2019 03:15:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zI3Vl3M1UoMRtsnKYnK2EWdXr3rDeU3lZrWSz3HhI3U=; b=FqhL9G8NpbYVOfQdJX+wCMSHLD jRwQxNXkb428qHsxyOHzw5QuBEANN7PfCgAu587/b7qbMYwrqYNzbRqV/FJb4cGgelYRu8G6rhLiY Iuwyz+5nZrfzoCy56DiglW5fCl3DPo70LZhjx9/uCfMNhUcPYMEBnaF2GL9vlbtjnZo0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zI3Vl3M1UoMRtsnKYnK2EWdXr3rDeU3lZrWSz3HhI3U=; b=IB2CmuMN+HLWxyBf8rKbjI6QCv I7fSj8bjFM2zQIZMgktUorXKmYW4912iEzEM0DqOPizeirBHzvswmKBHr32YGmfWDSAq593+ER0gG 7jwbPJFbW88vZkaDWJsLXhcdnkkbGM3vW8kMpCFoNvdsaZYMaanFcQoUOAlfKoEf67Zo=; Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hqUDr-00EXTk-0e for linux-f2fs-devel@lists.sourceforge.net; Thu, 25 Jul 2019 03:15:17 +0000 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id CFDA1E13BD828B343EFF; Thu, 25 Jul 2019 11:15:07 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.213) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 25 Jul 2019 11:15:02 +0800 To: Icenowy Zheng , Jaegeuk Kim References: <20190725030852.33161-1-icenowy@aosc.io> From: Chao Yu Message-ID: <07060e23-bc6f-5d35-a7f3-e75c8ebb3b65@huawei.com> Date: Thu, 25 Jul 2019 11:15:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190725030852.33161-1-icenowy@aosc.io> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1hqUDr-00EXTk-0e Subject: Re: [f2fs-dev] [PATCH v2] f2fs: use EINVAL for superblock with invalid magic X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2019/7/25 11:08, Icenowy Zheng wrote: > The kernel mount_block_root() function expects -EACESS or -EINVAL for a > unmountable filesystem when trying to mount the root with different > filesystem types. > > However, in 5.3-rc1 the behavior when F2FS code cannot find valid block > changed to return -EFSCORRUPTED(-EUCLEAN), and this error code makes > mount_block_root() fail when trying to probe F2FS. > > When the magic number of the superblock mismatches, it has a high > probability that it's just not a F2FS. In this case return -EINVAL seems > to be a better result, and this return value can make mount_block_root() > probing work again. > > Return -EINVAL when the superblock has magic mismatch, -EFSCORRUPTED in > other cases (the magic matches but the superblock cannot be recognized). > > Fixes: 10f966bbf521 ("f2fs: use generic EFSBADCRC/EFSCORRUPTED") > Signed-off-by: Icenowy Zheng Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel