* [f2fs-dev] [PATCH -next] f2fs: remove the unnecessary check in f2fs_xattr_fiemap
@ 2022-09-23 7:17 Zhang Qilong via Linux-f2fs-devel
2022-09-29 3:40 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Qilong via Linux-f2fs-devel @ 2022-09-23 7:17 UTC (permalink / raw)
To: jaegeuk, chao; +Cc: linux-f2fs-devel
Whehter or not error occurs, checking "err == 1" is unnecessary
in f2fs_xattr_fiemap(), and just remove it here.
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
fs/f2fs/data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 7d656bf51c52..4a8333b1bcaa 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1818,7 +1818,7 @@ static int f2fs_xattr_fiemap(struct inode *inode,
err = fiemap_fill_next_extent(fieinfo, 0, phys, len, flags);
trace_f2fs_fiemap(inode, 0, phys, len, flags, err);
- if (err || err == 1)
+ if (err)
return err;
}
--
2.25.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [f2fs-dev] [PATCH -next] f2fs: remove the unnecessary check in f2fs_xattr_fiemap
2022-09-23 7:17 [f2fs-dev] [PATCH -next] f2fs: remove the unnecessary check in f2fs_xattr_fiemap Zhang Qilong via Linux-f2fs-devel
@ 2022-09-29 3:40 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2022-09-29 3:40 UTC (permalink / raw)
To: Zhang Qilong, jaegeuk; +Cc: linux-f2fs-devel
On 2022/9/23 15:17, Zhang Qilong wrote:
> Whehter or not error occurs, checking "err == 1" is unnecessary
> in f2fs_xattr_fiemap(), and just remove it here.
>
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-29 3:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-23 7:17 [f2fs-dev] [PATCH -next] f2fs: remove the unnecessary check in f2fs_xattr_fiemap Zhang Qilong via Linux-f2fs-devel
2022-09-29 3:40 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).