From: Andreas Gruenbacher <andreas.gruenbacher-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-f2fs-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Mark Fasheh <mfasheh-IBi9RG/b67k@public.gmane.org>,
Joel Becker <jlbec-aKy9MeLSZ9dg9hUCZPvPmw@public.gmane.org>,
reiserfs-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org,
jfs-discussion-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
Subject: Re: [PATCH 04/18] fs: add generic xattr_acl handlers
Date: Thu, 12 Dec 2013 20:07:54 +0100 (CET) [thread overview]
Message-ID: <1342716144.69126.1386875274180.JavaMail.zimbra@linbit.com> (raw)
In-Reply-To: <20131211104527.044064384-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org>
Christoph,
> +static int
> +posix_acl_xattr_set(struct dentry *dentry, const char *name,
> + const void *value, size_t size, int flags, int type)
> +{
> + struct inode *inode = dentry->d_inode;
> + struct posix_acl *acl = NULL;
> + int ret;
> +
> + if (!IS_POSIXACL(inode))
> + return -EOPNOTSUPP;
> + if (S_ISLNK(inode->i_mode) || !inode->i_op->set_acl)
> + return -EOPNOTSUPP;
Sama here, I would remove the S_ISLNK() check.
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-12-12 19:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 10:42 [PATCH 00/18] Consolidate Posix ACL implementation V2 Christoph Hellwig
2013-12-11 10:42 ` [PATCH 01/18] reiserfs: prefix ACL symbols with reiserfs_ Christoph Hellwig
2013-12-11 10:42 ` [PATCH 02/18] fs: add get_acl helper Christoph Hellwig
2013-12-12 19:06 ` Andreas Gruenbacher
2013-12-12 21:04 ` Christoph Hellwig
2013-12-11 10:42 ` [PATCH 03/18] fs: add a set_acl inode operation Christoph Hellwig
2013-12-11 10:42 ` [PATCH 04/18] fs: add generic xattr_acl handlers Christoph Hellwig
[not found] ` <20131211104527.044064384-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org>
2013-12-12 19:07 ` Andreas Gruenbacher [this message]
2013-12-11 10:42 ` [PATCH 05/18] fs: make posix_acl_chmod more useful Christoph Hellwig
2013-12-12 19:07 ` Andreas Gruenbacher
2013-12-12 21:05 ` Christoph Hellwig
2013-12-11 10:42 ` [PATCH 06/18] fs: make posix_acl_create " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 07/18] btrfs: use generic posix ACL infrastructure Christoph Hellwig
2013-12-11 10:42 ` [PATCH 08/18] ext2/3/4: " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 09/18] f2fs: " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 10/18] hfsplus: " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 11/18] jffs2: " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 12/18] ocfs2: " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 13/18] reiserfs: " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 14/18] xfs: " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 15/18] jfs: " Christoph Hellwig
2013-12-11 10:42 ` [PATCH 16/18] gfs2: " Christoph Hellwig
2013-12-11 10:52 ` [Cluster-devel] " Steven Whitehouse
2013-12-12 19:08 ` Andreas Gruenbacher
2013-12-12 21:05 ` Christoph Hellwig
2013-12-11 10:43 ` [PATCH 17/18] nfs: use generic posix ACL infrastructure for v3 Posix ACLs Christoph Hellwig
2013-12-11 10:43 ` [PATCH 18/18] fs: remove generic_acl Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2013-12-01 11:59 [PATCH 00/18] Consolidate Posix ACL implementation Christoph Hellwig
2013-12-01 11:59 ` [PATCH 04/18] fs: add generic xattr_acl handlers Christoph Hellwig
2013-12-02 20:59 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342716144.69126.1386875274180.JavaMail.zimbra@linbit.com \
--to=andreas.gruenbacher-63ez5xqkn6dqt0dzr+alfa@public.gmane.org \
--cc=cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=jfs-discussion-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=jlbec-aKy9MeLSZ9dg9hUCZPvPmw@public.gmane.org \
--cc=linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-f2fs-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mfasheh-IBi9RG/b67k@public.gmane.org \
--cc=reiserfs-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
--cc=xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).