From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
To: Huajun Li <huajun.li.lee@gmail.com>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Huajun Li <huajun.li@intel.com>,
Haicheng Li <haicheng.li@linux.intel.com>,
Weihong Xu <weihong.xu@intel.com>
Subject: Re: [f2fs-dev 5/5] f2fs: Handle inline data operations
Date: Mon, 28 Oct 2013 21:44:55 +0900 [thread overview]
Message-ID: <1382964295.992.122.camel@kjgkr> (raw)
In-Reply-To: <1382716919-23345-6-git-send-email-huajun.li.lee@gmail.com>
Hi,
2013-10-26 (토), 00:01 +0800, Huajun Li:
> From: Huajun Li <huajun.li@intel.com>
>
[snip]
>
> @@ -538,7 +553,7 @@ static int f2fs_write_data_page(struct page *page,
> loff_t i_size = i_size_read(inode);
> const pgoff_t end_index = ((unsigned long long) i_size)
> >> PAGE_CACHE_SHIFT;
> - unsigned offset;
> + unsigned offset = 0;
> bool need_balance_fs = false;
> int err = 0;
>
> @@ -572,7 +587,14 @@ write:
> err = do_write_data_page(page);
> } else {
> f2fs_lock_op(sbi);
> - err = do_write_data_page(page);
> + if (test_opt(sbi, INLINE_DATA) && (i_size <= MAX_INLINE_DATA)) {
> + err = f2fs_write_inline_data(inode, page, offset);
> + ClearPageDirty(page);
Don't need to call ClearPageDirty(page).
> + f2fs_unlock_op(sbi);
> + goto out;
> + } else {
> + err = do_write_data_page(page);
> + }
> f2fs_unlock_op(sbi);
> need_balance_fs = true;
>
--
Jaegeuk Kim
Samsung
next prev parent reply other threads:[~2013-10-28 12:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 16:01 [f2fs-dev 0/5] f2fs: Enable f2fs support inline data Huajun Li
2013-10-25 16:01 ` [f2fs-dev 1/5] f2fs: Add flags and helpers to " Huajun Li
2013-10-25 16:01 ` [f2fs-dev 2/5] f2fs: Add a new mount option: inline_data Huajun Li
2013-10-25 16:01 ` [f2fs-dev 3/5] f2fs: Add a new function: f2fs_reserve_block() Huajun Li
[not found] ` <1382962607.992.104.camel@kjgkr>
2013-10-28 12:28 ` Jaegeuk Kim
2013-10-28 16:53 ` Huajun Li
2013-10-29 0:56 ` Jaegeuk Kim
2013-10-29 15:27 ` Huajun Li
2013-10-25 16:01 ` [f2fs-dev 4/5] f2fs: Key functions to handle inline data Huajun Li
2013-10-28 12:43 ` Jaegeuk Kim
2013-10-28 17:20 ` Huajun Li
2013-10-29 1:06 ` Jaegeuk Kim
2013-10-29 15:33 ` Huajun Li
2013-10-25 16:01 ` [f2fs-dev 5/5] f2fs: Handle inline data operations Huajun Li
2013-10-28 12:44 ` Jaegeuk Kim [this message]
2013-10-28 16:56 ` Huajun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382964295.992.122.camel@kjgkr \
--to=jaegeuk.kim@samsung.com \
--cc=haicheng.li@linux.intel.com \
--cc=huajun.li.lee@gmail.com \
--cc=huajun.li@intel.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weihong.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).