From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
To: Huajun Li <huajun.li.lee@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, Huajun Li <huajun.li@intel.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] No need to do recovery if there is no available CP
Date: Mon, 04 Nov 2013 10:24:13 +0900 [thread overview]
Message-ID: <1383528253.14041.53.camel@kjgkr> (raw)
In-Reply-To: <1383491301-11460-1-git-send-email-huajun.li.lee@gmail.com>
2013-11-03 (일), 23:08 +0800, Huajun Li:
> From: Huajun Li <huajun.li@intel.com>
>
> Normally we expect an empty partition after formatting by
> mkfs.f2fs. But in this case, when we format a dirty partition and mount
> it again. The former file will be recovered and available again! and
> kernel log shows a recovery procedure is evoked.
> This patch adds a new flag CP_EXIST_FLAG to indicate whether is a
> available CP, and do recovery only when this flag is set.
IMO, mkfs.f2fs should do the right thing to avoid this.
If storage does not support discard, mkfs.f2fs can simply address the
problem by writing one node block with zeros to prevent this.
And, if you introduce a new flag, mkfs.f2fs should do the same thing,
which means that mkfs.f2fs also needs to set the CP_EXIST_FLAG.
So then, it could not fix the bug.
How do you think?
--
Jaegeuk Kim
Samsung
------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2013-11-04 1:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-03 15:08 [PATCH 1/1] No need to do recovery if there is no available CP Huajun Li
2013-11-04 1:24 ` Jaegeuk Kim [this message]
2013-11-04 15:40 ` Huajun Li
2013-11-05 4:48 ` Jaegeuk Kim
2013-11-05 13:28 ` Huajun Li
2013-11-11 4:33 ` Jaegeuk Kim
2013-11-11 6:06 ` Huajun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383528253.14041.53.camel@kjgkr \
--to=jaegeuk.kim@samsung.com \
--cc=huajun.li.lee@gmail.com \
--cc=huajun.li@intel.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).