Re: [PATCH] f2fs: remove unneeded code in punch_hole

[Jaegeuk Kim <jaegeuk.kim@samsung.com>]

Got it.

But, with this patch, we can also remove the parameter, int mode, in
punch_hole().
If no objection, I'll fix that in your patch.
Thanks,

2013-11-22 (금), 16:52 +0800, Chao Yu:
> Because FALLOC_FL_PUNCH_HOLE flag must be ORed with FALLOC_FL_KEEP_SIZE 
> in fallocate, so we could remove the useless 'keep size' branch code which 
> will never be excuted in punch_hole.
> 
> Signed-off-by: Chao Yu <chao2.yu@samsung.com>
> Signed-off-by: Fan Li <fanofcode.li@samsung.com>
> ---
>  fs/f2fs/file.c |    6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 7d714f4..0087d2a 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -499,12 +499,6 @@ static int punch_hole(struct inode *inode, loff_t offset, loff_t len, int mode)
>  		}
>  	}
>  
> -	if (!(mode & FALLOC_FL_KEEP_SIZE) &&
> -		i_size_read(inode) <= (offset + len)) {
> -		i_size_write(inode, offset);
> -		mark_inode_dirty(inode);
> -	}
> -
>  	return ret;
>  }
>  

-- 
Jaegeuk Kim
Samsung



------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel