RE: [f2fs-dev] [PATCH] f2fs: refactor bio-related operations

[Jaegeuk Kim <jaegeuk.kim@samsung.com>]

Hi,

2013-12-02 (월), 12:47 +0800, Chao Yu:
> Hi,
> 
> Some comments as following.
> 
> > -----Original Message-----
> > From: Jaegeuk Kim [mailto:jaegeuk.kim@samsung.com]
> > Sent: Saturday, November 30, 2013 2:26 PM
> > Cc: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net
> > Subject: [f2fs-dev] [PATCH] f2fs: refactor bio-related operations
> > 
> 
> [snip]
> 
> > +void f2fs_submit_page_mbio(struct f2fs_sb_info *sbi, struct page *page,
> > +			block_t blk_addr, enum page_type type, int rw)
> > +{
> > +	enum page_type btype = PAGE_TYPE_OF_BIO(type);
> > +	struct block_device *bdev = sbi->sb->s_bdev;
> > +	struct f2fs_bio_info *io;
> > +	int bio_blocks;
> > +
> > +	io = is_read_io(rw) ? &sbi->read_io : &sbi->write_io[btype];
> > +
> > +	verify_block_addr(sbi, blk_addr);
> > +
> > +	mutex_lock(&io->io_mutex);
> > +
> > +	if (!is_read_io(rw))
> > +		inc_page_count(sbi, F2FS_WRITEBACK);
> > +
> > +	if (io->bio && io->last_block_in_bio != blk_addr - 1)
> > +		__submit_merged_bio(sbi, io, type, true, rw);
> > +alloc_new:
> > +	if (io->bio == NULL) {
> > +		bio_blocks = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
> > +		io->bio = __bio_alloc(bdev, bio_blocks);
> > +		io->bio->bi_sector = SECTOR_FROM_BLOCK(sbi, blk_addr);
> > +		io->bio->bi_end_io = is_read_io(rw) ? f2fs_read_end_io :
> > +							f2fs_write_end_io;
> > +		/*
> > +		 * The end_io will be assigned at the sumbission phase.
> > +		 * Until then, let bio_add_page() merge consecutive IOs as much
> > +		 * as possible.
> > +		 */
> > +	}
> > +
> > +	if (bio_add_page(io->bio, page, PAGE_CACHE_SIZE, 0) <
> > +							PAGE_CACHE_SIZE) {
> > +		__submit_merged_bio(sbi, io, type, true, rw);
> > +		io->bio = NULL;
> 
> We should remove the redundant code " io->bio = NULL;" here,
> because __submit_merged_bio does the same job.

Agreed.

> 
> [snip]
> 
> >  /*
> >   * data.c
> >   */
> > +void f2fs_submit_merged_bio(struct f2fs_sb_info *, enum page_type, bool, int);
> > +int f2fs_submit_page_bio(struct f2fs_sb_info *, struct page *, block_t, int);
> 
> Redundant to the following code.

Ah, agreed.
Thank you for the review. :)

-- 
Jaegeuk Kim
Samsung

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html