Re: [patch] f2fs: checking for IS_ERR() instead of NULL

[Jaegeuk Kim <jaegeuk.kim@samsung.com>]

Thank you for the patch.
This was already fixed in the original patch with an issue trigger by
Chao Yu before.
I rebased it before, so that it seems you need to pull the f2fs again.
Thanks,

2014-01-09 (목), 08:28 +0300, Dan Carpenter:
> grab_cache_page_write_begin() returns NULL on error, it doesn't return
> error pointers.
> 
> Fixes: e18c65b2ac91 ('f2fs: key functions to handle inline data')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c
> index 69a923e38f0c..e0d800a1d79f 100644
> --- a/fs/f2fs/inline.c
> +++ b/fs/f2fs/inline.c
> @@ -131,8 +131,8 @@ int f2fs_convert_inline_data(struct inode *inode, pgoff_t to_size)
>  		return 0;
>  
>  	page = grab_cache_page_write_begin(inode->i_mapping, 0, AOP_FLAG_NOFS);
> -	if (IS_ERR(page))
> -		return PTR_ERR(page);
> +	if (!page)
> +		return -ENOMEM;
>  
>  	err = __f2fs_convert_inline_data(inode, page);
>  	f2fs_put_page(page, 1);

-- 
Jaegeuk Kim
Samsung

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html