From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
f2fs <linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [PATCH 1/7] f2fs: put the bio when issue_flush completed
Date: Mon, 14 Apr 2014 10:36:15 +0900 [thread overview]
Message-ID: <1397439375.24638.20.camel@kjgkr> (raw)
In-Reply-To: <5347BAAF.9030004@cn.fujitsu.com>
Hi Gu,
Merged.
thank you. :)
2014-04-11 (금), 17:49 +0800, Gu Zheng:
> Put the bio when the flush cmd issued, it also can fix the following
> kmemleak:
> unreferenced object 0xffff8800270c73c0 (size 200):
> comm "f2fs_flush-7:0", pid 27161, jiffies 4312127988 (age 988.503s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 40 07 81 19 01 88 ff ff ........@.......
> 01 00 00 00 00 00 00 f0 11 14 00 00 00 00 00 00 ................
> backtrace:
> [<ffffffff81559866>] kmemleak_alloc+0x72/0x96
> [<ffffffff81156f7e>] slab_post_alloc_hook+0x28/0x2a
> [<ffffffff811595b1>] kmem_cache_alloc+0xec/0x157
> [<ffffffff8111924d>] mempool_alloc_slab+0x15/0x17
> [<ffffffff81119513>] mempool_alloc+0x71/0x138
> [<ffffffff81193548>] bio_alloc_bioset+0x93/0x18c
> [<ffffffffa040f857>] issue_flush_thread+0x8d/0x145 [f2fs]
> [<ffffffff8107ac16>] kthread+0xba/0xc2
> [<ffffffff81571b2c>] ret_from_fork+0x7c/0xb0
> [<ffffffffffffffff>] 0xffffffffffffffff
>
> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
> ---
> fs/f2fs/segment.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 085f548..524b7ed 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -226,6 +226,7 @@ repeat:
> next = cmd->next;
> complete(&cmd->wait);
> }
> + bio_put(bio);
> sm_i->dispatch_list = NULL;
> }
>
--
Jaegeuk Kim
Samsung
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2014-04-14 1:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 9:49 [PATCH 1/7] f2fs: put the bio when issue_flush completed Gu Zheng
2014-04-14 1:36 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397439375.24638.20.camel@kjgkr \
--to=jaegeuk.kim@samsung.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).