* [PATCH] f2fs: Remove pointless bit testing in f2fs_delete_entry()
@ 2014-10-23 12:40 Jan Kara
0 siblings, 0 replies; only message in thread
From: Jan Kara @ 2014-10-23 12:40 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: Jan Kara, linux-f2fs-devel
There's no point in using test_and_clear_bit_le() when we don't use the
return value of the function. Just use clear_bit_le() instead.
Coverity-id: 1016434
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/f2fs/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
index b54f87149c09..c49f83956773 100644
--- a/fs/f2fs/dir.c
+++ b/fs/f2fs/dir.c
@@ -579,7 +579,7 @@ void f2fs_delete_entry(struct f2fs_dir_entry *dentry, struct page *page,
dentry_blk = page_address(page);
bit_pos = dentry - dentry_blk->dentry;
for (i = 0; i < slots; i++)
- test_and_clear_bit_le(bit_pos + i, &dentry_blk->dentry_bitmap);
+ clear_bit_le(bit_pos + i, &dentry_blk->dentry_bitmap);
/* Let's check and deallocate this dentry page */
bit_pos = find_next_bit_le(&dentry_blk->dentry_bitmap,
--
1.8.1.4
------------------------------------------------------------------------------
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-10-23 12:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-23 12:40 [PATCH] f2fs: Remove pointless bit testing in f2fs_delete_entry() Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).