From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH 2/2] defrag.f2fs: return error if there is no space
Date: Thu, 17 Dec 2015 09:23:03 -0800 [thread overview]
Message-ID: <1450372983-84005-2-git-send-email-jaegeuk@kernel.org> (raw)
In-Reply-To: <1450372983-84005-1-git-send-email-jaegeuk@kernel.org>
This patch checks whether there is a space or not to allocate new blocks.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fsck/mount.c | 28 ++++++++++++++++++----------
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/fsck/mount.c b/fsck/mount.c
index 735ed90..4b38df8 100644
--- a/fsck/mount.c
+++ b/fsck/mount.c
@@ -11,6 +11,20 @@
#include "fsck.h"
#include <locale.h>
+static u32 get_free_segments(struct f2fs_sb_info *sbi)
+{
+ u32 i, free_segs = 0;
+
+ for (i = 0; i < TOTAL_SEGS(sbi); i++) {
+ struct seg_entry *se = get_seg_entry(sbi, i);
+
+ if (se->valid_blocks == 0x0 &&
+ !IS_CUR_SEGNO(sbi, i, NO_CHECK_TYPE))
+ free_segs++;
+ }
+ return free_segs;
+}
+
void print_inode_info(struct f2fs_inode *inode, int name)
{
unsigned int i = 0;
@@ -1376,6 +1390,9 @@ int find_next_free_block(struct f2fs_sb_info *sbi, u64 *to, int left, int type)
u32 segno;
u64 offset;
+ if (get_free_segments(sbi) <= SM_I(sbi)->reserved_segments + 1)
+ return -1;
+
while (*to >= SM_I(sbi)->main_blkaddr &&
*to < F2FS_RAW_SUPER(sbi)->block_count) {
segno = GET_SEGNO(sbi, *to);
@@ -1543,10 +1560,8 @@ void write_checkpoint(struct f2fs_sb_info *sbi)
struct f2fs_checkpoint *cp = F2FS_CKPT(sbi);
struct f2fs_super_block *sb = F2FS_RAW_SUPER(sbi);
block_t orphan_blks = 0;
- u32 free_segs = 0;
unsigned long long cp_blk_no;
u32 flags = CP_UMOUNT_FLAG;
- unsigned int segno;
int i, ret;
u_int32_t crc = 0;
@@ -1557,14 +1572,7 @@ void write_checkpoint(struct f2fs_sb_info *sbi)
set_cp(ckpt_flags, flags);
- for (segno = 0; segno < TOTAL_SEGS(sbi); segno++) {
- struct seg_entry *se = get_seg_entry(sbi, segno);
-
- if (se->valid_blocks == 0x0 &&
- !IS_CUR_SEGNO(sbi, segno, NO_CHECK_TYPE))
- free_segs++;
- }
- set_cp(free_segment_count, free_segs);
+ set_cp(free_segment_count, get_free_segments(sbi));
set_cp(cp_pack_total_block_count, 8 + orphan_blks + get_sb(cp_payload));
crc = f2fs_cal_crc32(F2FS_SUPER_MAGIC, cp, CHECKSUM_OFFSET);
--
2.5.4 (Apple Git-61)
------------------------------------------------------------------------------
prev parent reply other threads:[~2015-12-17 17:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 17:23 [PATCH 1/2] defrag.f2fs: eliminate unexpected journal entries Jaegeuk Kim
2015-12-17 17:23 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450372983-84005-2-git-send-email-jaegeuk@kernel.org \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).