From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH 1/2] f2fs: avoid multiple node page writes due to inline_data
Date: Sat, 23 Jan 2016 12:15:47 -0800 [thread overview]
Message-ID: <1453580148-61861-1-git-send-email-jaegeuk@kernel.org> (raw)
The sceanrio is:
1. create fully node blocks
2. flush node blocks
3. write inline_data for all the node blocks again
4. flush node blocks redundantly
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/data.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 8d0d9ec..011456e 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1622,14 +1622,22 @@ static int f2fs_write_end(struct file *file,
trace_f2fs_write_end(inode, pos, len, copied);
- set_page_dirty(page);
-
if (pos + copied > i_size_read(inode)) {
i_size_write(inode, pos + copied);
mark_inode_dirty(inode);
- update_inode_page(inode);
}
+ if (f2fs_has_inline_data(inode) &&
+ is_inode_flag_set(F2FS_I(inode), FI_DATA_EXIST)) {
+ int err = f2fs_write_inline_data(inode, page);
+ if (err)
+ set_page_dirty(page);
+ } else {
+ set_page_dirty(page);
+ }
+
+ f2fs_write_inode(inode, NULL);
+
f2fs_put_page(page, 1);
f2fs_update_time(F2FS_I_SB(inode), REQ_TIME);
return copied;
--
2.6.3
next reply other threads:[~2016-01-23 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 20:15 Jaegeuk Kim [this message]
2016-01-23 20:15 ` [PATCH 2/2] f2fs: fix to overcome inline_data floods Jaegeuk Kim
2016-01-25 9:49 ` [f2fs-dev] " Chao Yu
2016-01-25 19:15 ` Jaegeuk Kim
2016-01-25 9:42 ` [f2fs-dev] [PATCH 1/2] f2fs: avoid multiple node page writes due to inline_data Chao Yu
2016-01-25 19:17 ` Jaegeuk Kim
2016-01-26 6:58 ` Chao Yu
2016-01-26 18:31 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453580148-61861-1-git-send-email-jaegeuk@kernel.org \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).