Re: [PATCH] f2fs: fix endianness of on-disk summary_footer

Re: [PATCH] f2fs: fix endianness of on-disk summary_footer

[Chao Yu]

Hi Sheng,

> -----Original Message-----
> From: Sheng Yong [mailto:shengyong1@huawei.com]
> Sent: Thursday, January 28, 2016 7:40 PM
> To: jaegeuk@kernel.org
> Cc: chao2.yu@samsung.com; linux-f2fs-devel@lists.sourceforge.net; shengyong1@huawei.com
> Subject: [PATCH] f2fs: fix endianness of on-disk summary_footer
> 
> Signed-off-by: Sheng Yong <shengyong1@huawei.com>

Nice catch!

Reviewed-by: Chao Yu <chao2.yu@samsung.com>

Thanks,

> ---
>  include/linux/f2fs_fs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h
> index 25c6324..2863274 100644
> --- a/include/linux/f2fs_fs.h
> +++ b/include/linux/f2fs_fs.h
> @@ -344,7 +344,7 @@ struct f2fs_summary {
> 
>  struct summary_footer {
>  	unsigned char entry_type;	/* SUM_TYPE_XXX */
> -	__u32 check_sum;		/* summary checksum */
> +	__le32 check_sum;		/* summary checksum */
>  } __packed;
> 
>  #define SUM_JOURNAL_SIZE	(F2FS_BLKSIZE - SUM_FOOTER_SIZE -\
> --
> 1.9.1



------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140

[PATCH] f2fs: fix endianness of on-disk summary_footer

[Sheng Yong]

Signed-off-by: Sheng Yong <shengyong1@huawei.com>
---
 include/linux/f2fs_fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h
index 25c6324..2863274 100644
--- a/include/linux/f2fs_fs.h
+++ b/include/linux/f2fs_fs.h
@@ -344,7 +344,7 @@ struct f2fs_summary {
 
 struct summary_footer {
 	unsigned char entry_type;	/* SUM_TYPE_XXX */
-	__u32 check_sum;		/* summary checksum */
+	__le32 check_sum;		/* summary checksum */
 } __packed;
 
 #define SUM_JOURNAL_SIZE	(F2FS_BLKSIZE - SUM_FOOTER_SIZE -\
-- 
1.9.1


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140