From: mchristi@redhat.com
To: linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org, konrad.wilk@oracle.com,
drbd-dev@lists.linbit.com, philipp.reisner@linbit.com,
lars.ellenberg@linbit.com, linux-raid@vger.kernel.org,
dm-devel@redhat.com, linux-fsdevel@vger.kernel.org,
linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-mtd@lists.infradead.org, target-devel@vger.kernel.org,
linux-btrfs@vger.kernel.org, osd-dev@open-osd.org,
xfs@oss.sgi.com, ocfs2-devel@oss.oracle.com
Cc: Mike Christie <mchristi@redhat.com>
Subject: [PATCH 25/35] target: set bi_op to REQ_OP
Date: Wed, 24 Feb 2016 13:48:02 -0600 [thread overview]
Message-ID: <1456343292-14535-26-git-send-email-mchristi@redhat.com> (raw)
In-Reply-To: <1456343292-14535-1-git-send-email-mchristi@redhat.com>
From: Mike Christie <mchristi@redhat.com>
This patch has the target modules set the bio bi_op to a REQ_OP, and
rq_flag_bits to bi_rw.
This patch is compile tested only.
Signed-off-by: Mike Christie <mchristi@redhat.com>
Acked-by: Nicholas Bellinger <nab@linux-iscsi.org>
---
drivers/target/target_core_iblock.c | 38 ++++++++++++++++++++++---------------
drivers/target/target_core_pscsi.c | 2 +-
2 files changed, 24 insertions(+), 16 deletions(-)
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index c352a64..8d3d197 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -312,7 +312,8 @@ static void iblock_bio_done(struct bio *bio)
}
static struct bio *
-iblock_get_bio(struct se_cmd *cmd, sector_t lba, u32 sg_num, int rw)
+iblock_get_bio(struct se_cmd *cmd, sector_t lba, u32 sg_num, int op,
+ int op_flags)
{
struct iblock_dev *ib_dev = IBLOCK_DEV(cmd->se_dev);
struct bio *bio;
@@ -334,7 +335,8 @@ iblock_get_bio(struct se_cmd *cmd, sector_t lba, u32 sg_num, int rw)
bio->bi_private = cmd;
bio->bi_end_io = &iblock_bio_done;
bio->bi_iter.bi_sector = lba;
- bio->bi_rw = rw;
+ bio->bi_op = op;
+ bio->bi_rw = op_flags;
return bio;
}
@@ -446,7 +448,7 @@ iblock_execute_write_same(struct se_cmd *cmd)
goto fail;
cmd->priv = ibr;
- bio = iblock_get_bio(cmd, block_lba, 1, WRITE);
+ bio = iblock_get_bio(cmd, block_lba, 1, REQ_OP_WRITE, 0);
if (!bio)
goto fail_free_ibr;
@@ -459,7 +461,8 @@ iblock_execute_write_same(struct se_cmd *cmd)
while (bio_add_page(bio, sg_page(sg), sg->length, sg->offset)
!= sg->length) {
- bio = iblock_get_bio(cmd, block_lba, 1, WRITE);
+ bio = iblock_get_bio(cmd, block_lba, 1, REQ_OP_WRITE,
+ 0);
if (!bio)
goto fail_put_bios;
@@ -645,7 +648,8 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents,
struct scatterlist *sg;
u32 sg_num = sgl_nents;
unsigned bio_cnt;
- int rw = 0;
+ int op_flags = 0;
+ int op = 0;
int i;
if (data_direction == DMA_TO_DEVICE) {
@@ -656,17 +660,20 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents,
* is not enabled, or if initiator set the Force Unit Access bit.
*/
if (q->flush_flags & REQ_FUA) {
- if (cmd->se_cmd_flags & SCF_FUA)
- rw = WRITE_FUA;
- else if (!(q->flush_flags & REQ_FLUSH))
- rw = WRITE_FUA;
- else
- rw = WRITE;
+ if (cmd->se_cmd_flags & SCF_FUA) {
+ op = REQ_OP_WRITE;
+ op_flags = WRITE_FUA;
+ } else if (!(q->flush_flags & REQ_FLUSH)) {
+ op = REQ_OP_WRITE;
+ op_flags = WRITE_FUA;
+ } else {
+ op = REQ_OP_WRITE;
+ }
} else {
- rw = WRITE;
+ op = REQ_OP_WRITE;
}
} else {
- rw = READ;
+ op = REQ_OP_READ;
}
ibr = kzalloc(sizeof(struct iblock_req), GFP_KERNEL);
@@ -680,7 +687,7 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents,
return 0;
}
- bio = iblock_get_bio(cmd, block_lba, sgl_nents, rw);
+ bio = iblock_get_bio(cmd, block_lba, sgl_nents, op, op_flags);
if (!bio)
goto fail_free_ibr;
@@ -704,7 +711,8 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents,
bio_cnt = 0;
}
- bio = iblock_get_bio(cmd, block_lba, sg_num, rw);
+ bio = iblock_get_bio(cmd, block_lba, sg_num, op,
+ op_flags);
if (!bio)
goto fail_put_bios;
diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c
index de18790..2cf915c 100644
--- a/drivers/target/target_core_pscsi.c
+++ b/drivers/target/target_core_pscsi.c
@@ -922,7 +922,7 @@ pscsi_map_sg(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents,
goto fail;
if (rw)
- bio->bi_rw |= REQ_WRITE;
+ bio->bi_op = REQ_OP_WRITE;
pr_debug("PSCSI: Allocated bio: %p,"
" dir: %s nr_vecs: %d\n", bio,
--
1.8.3.1
next prev parent reply other threads:[~2016-02-24 19:48 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 19:47 [PATCH 00/35 v4] separate operations from flags in the bio/request structs mchristi
2016-02-24 19:47 ` [PATCH 01/35] block/fs/drivers: remove rw argument from submit_bio mchristi
2016-02-24 19:47 ` [PATCH 02/35] block: add REQ_OP definitions and bi_op/op fields mchristi
2016-02-24 19:47 ` [PATCH 03/35] block, fs, mm, drivers: set bi_op to REQ_OP mchristi
2016-02-24 19:47 ` [PATCH 04/35] fs: have submit_bh users pass in op and flags separately mchristi
2016-02-24 19:47 ` [PATCH 05/35] fs: have ll_rw_block " mchristi
2016-02-24 19:47 ` [PATCH 06/35] direct-io: set bi_op to REQ_OP mchristi
2016-02-24 19:47 ` [PATCH 07/35] btrfs: have submit_one_bio users setup bio bi_op mchristi
2016-02-24 19:47 ` [PATCH 08/35] btrfs: set bi_op tp REQ_OP mchristi
2016-02-24 19:47 ` [PATCH 09/35] btrfs: update __btrfs_map_block for bi_op transition mchristi
2016-02-24 19:47 ` [PATCH 10/35] btrfs: don't pass rq_flag_bits if there is a bio mchristi
2016-02-24 19:47 ` [PATCH 11/35] f2fs: set bi_op to REQ_OP mchristi
2016-02-24 19:47 ` [PATCH 12/35] gfs2: " mchristi
2016-02-24 19:47 ` [PATCH 13/35] xfs: " mchristi
2016-02-24 19:47 ` [PATCH 14/35] hfsplus: " mchristi
2016-02-24 19:47 ` [PATCH 15/35] mpage: " mchristi
2016-02-24 19:47 ` [PATCH 16/35] nilfs: " mchristi
2016-02-24 19:47 ` [PATCH 17/35] ocfs2: " mchristi
2016-02-24 19:47 ` [PATCH 18/35] pm: " mchristi
2016-02-24 19:47 ` [PATCH 19/35] dm: " mchristi
2016-02-24 19:47 ` [PATCH 20/35] dm: pass dm stats data dir instead of bi_rw mchristi
2016-02-24 19:47 ` [PATCH 21/35] bcache: set bi_op to REQ_OP mchristi
2016-02-24 19:47 ` [PATCH 22/35] drbd: " mchristi
2016-02-24 19:48 ` [PATCH 23/35] md/raid: " mchristi
2016-02-24 19:48 ` [PATCH 24/35] xen: " mchristi
2016-02-24 19:48 ` mchristi [this message]
2016-02-24 19:48 ` [PATCH 26/35] block: set op " mchristi
2016-02-24 22:10 ` kbuild test robot
2016-02-24 19:48 ` [PATCH 27/35] drivers: set request " mchristi
2016-02-24 19:48 ` [PATCH 28/35] blktrace: get op from req->op/bio->bi_op mchristi
2016-02-24 19:48 ` [PATCH 29/35] ide cd: do not set REQ_WRITE on requests mchristi
2016-02-24 19:48 ` [PATCH 30/35] block, fs, drivers: do not test bi_rw for REQ_OPs mchristi
2016-02-24 19:48 ` [PATCH 31/35] block, fs: remove old REQ definitions mchristi
2016-02-25 0:54 ` kbuild test robot
2016-02-24 19:48 ` [PATCH 32/35] block: shrink bi_rw and bi_op mchristi
2016-02-24 19:48 ` [PATCH 33/35] block, drivers: add REQ_OP_FLUSH operation mchristi
2016-02-24 19:48 ` [PATCH 34/35] block: add QUEUE_FLAGs for flush and fua mchristi
2016-02-24 19:48 ` [PATCH 35/35] block, drivers, fs: rename REQ_FLUSH to REQ_PREFLUSH mchristi
2016-02-29 17:13 ` [PATCH 00/35 v4] separate operations from flags in the bio/request structs Christoph Hellwig
2016-02-29 17:30 ` Mike Christie
-- strict thread matches above, loose matches on Subject: below --
2016-01-11 20:20 [PATCH 00/35 v3] eparate " mchristi
2016-01-11 20:21 ` [PATCH 25/35] target: set bi_op to REQ_OP mchristi
2016-01-05 20:53 [PATCH 00/35 v2] separate operations from flags in the bio/request structs mchristi
2016-01-05 20:53 ` [PATCH 25/35] target: set bi_op to REQ_OP mchristi
2016-01-06 19:06 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456343292-14535-26-git-send-email-mchristi@redhat.com \
--to=mchristi@redhat.com \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=konrad.wilk@oracle.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=osd-dev@open-osd.org \
--cc=philipp.reisner@linbit.com \
--cc=target-devel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).