From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Lin Subject: [PATCH 5/8] f2fs: f2fs: check inline flag ahead for f2fs_inline_data_fiemap Date: Fri, 11 Mar 2016 11:28:58 +0800 Message-ID: <1457666938-14518-1-git-send-email-shawn.lin@rock-chips.com> References: <1457666880-14311-1-git-send-email-shawn.lin@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1aeDsw-0004BR-0S for linux-f2fs-devel@lists.sourceforge.net; Fri, 11 Mar 2016 03:37:06 +0000 Received: from lucky1.263xmail.com ([211.157.147.133]) by sog-mx-3.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1aeDsv-0004t6-7n for linux-f2fs-devel@lists.sourceforge.net; Fri, 11 Mar 2016 03:37:05 +0000 In-Reply-To: <1457666880-14311-1-git-send-email-shawn.lin@rock-chips.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Jaegeuk Kim Cc: Shawn Lin , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net No matter inline data flag is set or not, get_node_page is going work now. But actually we can avoid it by puting the check of inline data flag in advance to save this cpu cycle. Signed-off-by: Shawn Lin --- fs/f2fs/inline.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c index 69a4806..394feee 100644 --- a/fs/f2fs/inline.c +++ b/fs/f2fs/inline.c @@ -566,15 +566,13 @@ int f2fs_inline_data_fiemap(struct inode *inode, struct page *ipage; int err = 0; + if (!f2fs_has_inline_data(inode)) + return -EAGAIN; + ipage = get_node_page(F2FS_I_SB(inode), inode->i_ino); if (IS_ERR(ipage)) return PTR_ERR(ipage); - if (!f2fs_has_inline_data(inode)) { - err = -EAGAIN; - goto out; - } - ilen = min_t(size_t, MAX_INLINE_DATA, i_size_read(inode)); if (start >= ilen) goto out; -- 2.3.7 ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785111&iu=/4140