From: Eric Biggers <ebiggers@google.com>
To: linux-fsdevel@vger.kernel.org
Cc: linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
"Theodore Y . Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Richard Weinberger <richard@nod.at>,
David Gstir <david@sigma-star.at>,
Eric Biggers <ebiggers@google.com>
Subject: [RFC PATCH 0/5] fscrypt error code cleanup
Date: Mon, 5 Dec 2016 11:12:43 -0800 [thread overview]
Message-ID: <1480965168-38747-1-git-send-email-ebiggers@google.com> (raw)
As suggested by Richard Weinberger, we need to agree on and document a clear set
of fscrypt-related error codes.
I identified several cases where the error codes are not consistent between or
within filesystems, or are ambiguous with other errors. This patchset proposes
several changes to resolve these problems.
I believe we do still have some flexibility to make changes to these error codes
since there are not many different users of filesystem-level encryption yet, and
depending on these specific errors would be unusual. There have also already
been cases where some of these error codes have changed before.
Currently this patchset depends on the following patch being applied first:
"fscrypto: move ioctl processing more fully into common code"
Eric Biggers (5):
fscrypt: use ENOKEY when file cannot be created w/o key
fscrypt: use ENOTDIR when setting encryption policy on nondirectory
fscrypt: use EEXIST when file already uses different policy
fscrypt: remove user-triggerable warning messages
fscrypt: pass up error codes from ->get_context()
fs/crypto/fname.c | 4 +--
fs/crypto/policy.c | 73 ++++++++++++++++++++----------------------------------
fs/ext4/ialloc.c | 2 +-
fs/ext4/namei.c | 4 ++-
fs/f2fs/dir.c | 5 +++-
fs/f2fs/namei.c | 4 +--
6 files changed, 39 insertions(+), 53 deletions(-)
--
2.8.0.rc3.226.g39d4020
next reply other threads:[~2016-12-05 19:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 19:12 Eric Biggers [this message]
2016-12-05 19:12 ` [RFC PATCH 1/5] fscrypt: use ENOKEY when file cannot be created w/o key Eric Biggers
2016-12-28 2:28 ` Theodore Ts'o
2016-12-05 19:12 ` [RFC PATCH 2/5] fscrypt: use ENOTDIR when setting encryption policy on nondirectory Eric Biggers
2016-12-28 2:28 ` Theodore Ts'o
2016-12-05 19:12 ` [RFC PATCH 3/5] fscrypt: use EEXIST when file already uses different policy Eric Biggers
2016-12-28 2:29 ` Theodore Ts'o
2016-12-05 19:12 ` [RFC PATCH 4/5] fscrypt: remove user-triggerable warning messages Eric Biggers
2016-12-28 3:14 ` Theodore Ts'o
2016-12-05 19:12 ` [RFC PATCH 5/5] fscrypt: pass up error codes from ->get_context() Eric Biggers
2016-12-28 3:26 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480965168-38747-1-git-send-email-ebiggers@google.com \
--to=ebiggers@google.com \
--cc=david@sigma-star.at \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).