From: Yunlei He <heyunlei@huawei.com>
To: jaegeuk@kernel.org, yuchao0@huawei.com,
linux-f2fs-devel@lists.sourceforge.net
Cc: heyunlei@huawei.com, morgan.wang@huawei.com
Subject: [PATCH] dump.f2fs: check block is valid or not before dump block info
Date: Tue, 22 Aug 2017 18:51:49 +0800 [thread overview]
Message-ID: <1503399109-32255-1-git-send-email-heyunlei@huawei.com> (raw)
This patch add a block validate check in dump.f2fs
Signed-off-by: Yunlei He <heyunlei@huawei.com>
---
fsck/dump.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/fsck/dump.c b/fsck/dump.c
index 22e2265..a33969c 100644
--- a/fsck/dump.c
+++ b/fsck/dump.c
@@ -507,6 +507,9 @@ int dump_info_from_blkaddr(struct f2fs_sb_info *sbi, u32 blk_addr)
int type;
struct f2fs_summary sum_entry;
struct node_info ni, ino_ni;
+ struct seg_entry * seg;
+ unsigned int segno;
+ u32 offset;
int ret = 0;
MSG(0, "\n== Dump data from block address ==\n\n");
@@ -538,6 +541,16 @@ int dump_info_from_blkaddr(struct f2fs_sb_info *sbi, u32 blk_addr)
return ret;
}
+ segno = GET_SEGNO(sbi, blk_addr);
+ offset = OFFSET_IN_SEG(sbi, blk_addr);
+ seg = get_seg_entry(sbi, segno);
+ if (f2fs_test_bit(offset, (const char *)seg->cur_valid_map)) {
+ MSG(0, "\nblk_addr: 0x%x is valid block\n", blk_addr);
+ } else {
+ MSG(0, "\nblk_addr: 0x%x is not valid block\n", blk_addr);
+ return ret;
+ }
+
type = get_sum_entry(sbi, blk_addr, &sum_entry);
nid = le32_to_cpu(sum_entry.nid);
@@ -545,8 +558,8 @@ int dump_info_from_blkaddr(struct f2fs_sb_info *sbi, u32 blk_addr)
DBG(1, "Note: blkaddr = main_blkaddr + segno * 512 + offset\n");
DBG(1, "Block_addr [0x%x]\n", blk_addr);
- DBG(1, " - Segno [0x%x]\n", GET_SEGNO(sbi, blk_addr));
- DBG(1, " - Offset [0x%x]\n", OFFSET_IN_SEG(sbi, blk_addr));
+ DBG(1, " - Segno [0x%x]\n", segno);
+ DBG(1, " - Offset [0x%x]\n", offset);
DBG(1, "SUM.nid [0x%x]\n", nid);
DBG(1, "SUM.type [%s]\n", type >= 0 ?
seg_type_name[type] :
--
1.9.1
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
next reply other threads:[~2017-08-22 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 10:51 Yunlei He [this message]
2017-08-24 13:32 ` [PATCH] dump.f2fs: check block is valid or not before dump block info Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503399109-32255-1-git-send-email-heyunlei@huawei.com \
--to=heyunlei@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=morgan.wang@huawei.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).