[PATCH v5] f2fs: stop issue discard if something wrong with f2fs

[PATCH v5] f2fs: stop issue discard if something wrong with f2fs

[Yunlei He]

v4->v5: move data corruption check to __submit_discard_cmd, in order to
control discard io submitted more accurately, besides, increase async
thread wait time if data corruption detected.

This patch stop async thread and umount process to issue discard
if something wrong with f2fs, which is similar to fstrim.

Signed-off-by: Yunlei He <heyunlei@huawei.com>
---
 fs/f2fs/segment.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index d923ef5..991d1a2 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -929,6 +929,9 @@ static void __submit_discard_cmd(struct f2fs_sb_info *sbi,
 	if (dc->state != D_PREP)
 		return;
 
+	if (is_sbi_flag_set(sbi, SBI_NEED_FSCK))
+		return;
+
 	trace_f2fs_issue_discard(dc->bdev, dc->start, dc->len);
 
 	dc->error = __blkdev_issue_discard(dc->bdev,
@@ -1410,6 +1413,10 @@ static int issue_discard_thread(void *data)
 			continue;
 		if (kthread_should_stop())
 			return 0;
+		if (is_sbi_flag_set(sbi, SBI_NEED_FSCK)) {
+			wait_ms = dpolicy.max_interval;
+			continue;
+		}
 
 		if (dcc->discard_wake)
 			dcc->discard_wake = 0;
-- 
1.9.1


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: [PATCH v5] f2fs: stop issue discard if something wrong with f2fs

[heyunlei]

>-----Original Message-----
>From: heyunlei
>Sent: Friday, April 13, 2018 11:08 AM
>To: jaegeuk@kernel.org; Yuchao (T); linux-f2fs-devel@lists.sourceforge.net
>Cc: Wangbintian; heyunlei; Zhangdianfang (Euler)
>Subject: [f2fs-dev][PATCH v5] f2fs: stop issue discard if something wrong with f2fs
>
>v4->v5: move data corruption check to __submit_discard_cmd, in order to
>control discard io submitted more accurately, besides, increase async
>thread wait time if data corruption detected.
>
>This patch stop async thread and umount process to issue discard
>if something wrong with f2fs, which is similar to fstrim.
>
>Signed-off-by: Yunlei He <heyunlei@huawei.com>
>---
> fs/f2fs/segment.c | 7 +++++++
> 1 file changed, 7 insertions(+)

Ping

Thanks.
>
>diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>index d923ef5..991d1a2 100644
>--- a/fs/f2fs/segment.c
>+++ b/fs/f2fs/segment.c
>@@ -929,6 +929,9 @@ static void __submit_discard_cmd(struct f2fs_sb_info *sbi,
> 	if (dc->state != D_PREP)
> 		return;
>
>+	if (is_sbi_flag_set(sbi, SBI_NEED_FSCK))
>+		return;
>+
> 	trace_f2fs_issue_discard(dc->bdev, dc->start, dc->len);
>
> 	dc->error = __blkdev_issue_discard(dc->bdev,
>@@ -1410,6 +1413,10 @@ static int issue_discard_thread(void *data)
> 			continue;
> 		if (kthread_should_stop())
> 			return 0;
>+		if (is_sbi_flag_set(sbi, SBI_NEED_FSCK)) {
>+			wait_ms = dpolicy.max_interval;
>+			continue;
>+		}
>
> 		if (dcc->discard_wake)
> 			dcc->discard_wake = 0;
>--
>1.9.1


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot