linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Yunlong Song <yunlong.song@huawei.com>
To: jaegeuk@kernel.org, chao@kernel.org, yuchao0@huawei.com,
	yunlong.song@icloud.com, yunlong.song@huawei.com
Cc: miaoxie@huawei.com, bintian.wang@huawei.com,
	shengyong1@huawei.com, heyunlei@huawei.com,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/5] f2fs: clear the remaining prefree_map of the section
Date: Thu, 12 Jul 2018 23:09:27 +0800	[thread overview]
Message-ID: <1531408170-45758-3-git-send-email-yunlong.song@huawei.com> (raw)
In-Reply-To: <1531408170-45758-1-git-send-email-yunlong.song@huawei.com>

For the case when sbi->segs_per_sec > 1, take section:segment = 5 for
example, if the section prefree_map is ...previous section | current
section (1 1 0 1 1) | next section..., then the start = x, end = x + 1,
after start = start_segno + sbi->segs_per_sec, start = x + 5, then it
will skip x + 3 and x + 4, but their bitmap is still set, which will
cause duplicated f2fs_issue_discard of this same section in the next
write_checkpoint, so fix it.

Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
---
 fs/f2fs/segment.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 47b6595..fd38b61 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1684,8 +1684,23 @@ void f2fs_clear_prefree_segments(struct f2fs_sb_info *sbi,
 		start = start_segno + sbi->segs_per_sec;
 		if (start < end)
 			goto next;
-		else
-			end = start - 1;
+		else {
+			start_segno = start;
+
+			while (1) {
+				start = find_next_bit(prefree_map, start_segno,
+									end + 1);
+				if (start >= start_segno)
+					break;
+				end = find_next_zero_bit(prefree_map, start_segno,
+										start + 1);
+				for (i = start; i < end; i++)
+					clear_bit(i, prefree_map);
+				dirty_i->nr_dirty[PRE] -= end - start;
+			}
+
+			end = start_segno - 1;
+		}
 	}
 	mutex_unlock(&dirty_i->seglist_lock);
 
-- 
1.8.5.2

  parent reply	other threads:[~2018-07-12 15:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12 15:09 [PATCH 0/5] f2fs: fix some bugs in lfs mode with large section Yunlong Song
2018-07-12 15:09 ` [PATCH 1/5] f2fs: do not set free of current section Yunlong Song
2018-07-13  3:10   ` Chao Yu
2018-07-12 15:09 ` Yunlong Song [this message]
2018-07-13  3:13   ` [PATCH 2/5] f2fs: clear the remaining prefree_map of the section Chao Yu
2018-07-13  3:28     ` Yunlong Song
2018-07-13  3:42       ` Chao Yu
2018-07-13  3:51         ` Yunlong Song
2018-07-13  8:59           ` Chao Yu
2018-07-17  9:12       ` Chao Yu
2018-07-12 15:09 ` [PATCH 3/5] f2fs: blk_finish_plug of submit_bio in lfs mode Yunlong Song
2018-07-13  3:14   ` Chao Yu
2018-07-12 15:09 ` [PATCH 4/5] f2fs: disable small discard " Yunlong Song
2018-07-13  3:17   ` Chao Yu
2018-07-13  3:39     ` Yunlong Song
2018-07-13  3:45       ` Chao Yu
2018-07-12 15:09 ` [PATCH 5/5] f2fs: do not __punch_discard_cmd " Yunlong Song
2018-07-13  3:26   ` Chao Yu
2018-07-13  3:42     ` Yunlong Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1531408170-45758-3-git-send-email-yunlong.song@huawei.com \
    --to=yunlong.song@huawei.com \
    --cc=bintian.wang@huawei.com \
    --cc=chao@kernel.org \
    --cc=heyunlei@huawei.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miaoxie@huawei.com \
    --cc=shengyong1@huawei.com \
    --cc=yuchao0@huawei.com \
    --cc=yunlong.song@icloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).