From: Yunlong Song <yunlong.song@huawei.com>
To: jaegeuk@kernel.org, chao@kernel.org, yuchao0@huawei.com,
yunlong.song@icloud.com, yunlong.song@huawei.com
Cc: miaoxie@huawei.com, bintian.wang@huawei.com,
shengyong1@huawei.com, heyunlei@huawei.com,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/5] f2fs: blk_finish_plug of submit_bio in lfs mode
Date: Thu, 12 Jul 2018 23:09:28 +0800 [thread overview]
Message-ID: <1531408170-45758-4-git-send-email-yunlong.song@huawei.com> (raw)
In-Reply-To: <1531408170-45758-1-git-send-email-yunlong.song@huawei.com>
Expand the blk_finish_plug action from blkzoned to normal lfs mode,
since plug will cause the out-of-order IO submission, which is not
friendly to flash in lfs mode.
Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
---
fs/f2fs/data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 70813a4..f12151d 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -263,7 +263,7 @@ static inline void __submit_bio(struct f2fs_sb_info *sbi,
if (type != DATA && type != NODE)
goto submit_io;
- if (f2fs_sb_has_blkzoned(sbi->sb) && current->plug)
+ if (test_opt(sbi, LFS) && current->plug)
blk_finish_plug(current->plug);
start = bio->bi_iter.bi_size >> F2FS_BLKSIZE_BITS;
--
1.8.5.2
next prev parent reply other threads:[~2018-07-12 15:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 15:09 [PATCH 0/5] f2fs: fix some bugs in lfs mode with large section Yunlong Song
2018-07-12 15:09 ` [PATCH 1/5] f2fs: do not set free of current section Yunlong Song
2018-07-13 3:10 ` Chao Yu
2018-07-12 15:09 ` [PATCH 2/5] f2fs: clear the remaining prefree_map of the section Yunlong Song
2018-07-13 3:13 ` Chao Yu
2018-07-13 3:28 ` Yunlong Song
2018-07-13 3:42 ` Chao Yu
2018-07-13 3:51 ` Yunlong Song
2018-07-13 8:59 ` Chao Yu
2018-07-17 9:12 ` Chao Yu
2018-07-12 15:09 ` Yunlong Song [this message]
2018-07-13 3:14 ` [PATCH 3/5] f2fs: blk_finish_plug of submit_bio in lfs mode Chao Yu
2018-07-12 15:09 ` [PATCH 4/5] f2fs: disable small discard " Yunlong Song
2018-07-13 3:17 ` Chao Yu
2018-07-13 3:39 ` Yunlong Song
2018-07-13 3:45 ` Chao Yu
2018-07-12 15:09 ` [PATCH 5/5] f2fs: do not __punch_discard_cmd " Yunlong Song
2018-07-13 3:26 ` Chao Yu
2018-07-13 3:42 ` Yunlong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531408170-45758-4-git-send-email-yunlong.song@huawei.com \
--to=yunlong.song@huawei.com \
--cc=bintian.wang@huawei.com \
--cc=chao@kernel.org \
--cc=heyunlei@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=shengyong1@huawei.com \
--cc=yuchao0@huawei.com \
--cc=yunlong.song@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).